Fix binary diff rendering.

Review Request #10766 — Created Oct. 26, 2019 and discarded — Latest diff uploaded

Information

Review Board
master

Reviewers

Follows up on previous binary file changes. This will allow the
frontend to render binary files for visual reviewing. This will
only display a diff if the binary file is a image. If the file is
a not a binary, exe for example, it will display this message
'This is a binary file. The content cannot be displayed.' This also
fixes problems where if the same commit with a binary is upload
multiple times the backend would hard fail. Now it returns without
doing anything.

Walked through a standard review process: posted changes,
interact with changes, commented, and posted changes. Also
covered by previouse tests written for image review UI.

Diff Revision 7 (Latest)

orig
1
2
3
4
5
6
7

Commits

First Last Summary ID Author
Debug statements and some backend fixes
cce36a415102bebecc26af8669378b2747212328 Ceegan Hale
Fix frontend diff ui script not running and remove debug statements
39e05b50ef7f8ff2e758f83cfc282d4e820f0dab Ceegan Hale
shorten line to adhere to max line length
bb8bf7fbaa1c845b22044320c34aaf7797866003 Ceegan Hale
use html instead of innerhtml
ad1c108f3969d54da1abf31e8f507a54c4dd14fc Ceegan Hale
address comments
921855571820bd43a761197d2c8742390127ae5d Ceegan Hale
reviewboard/attachments/forms.py
reviewboard/attachments/managers.py
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
reviewboard/testing/testcase.py
reviewboard/webapi/resources/draft_filediff.py
Loading...