flake8
-
reviewboard/attachments/managers.py (Diff revision 1) Show all issues -
-
-
reviewboard/webapi/resources/draft_filediff.py (Diff revision 1) E501 line too long (103 > 79 characters)
Review Request #10766 — Created Oct. 26, 2019 and updated
Follows up on previous binary file changes. This will allow the
frontend to render binary files for visual reviewing. This will
only display a diff if the binary file is a image. If the file is
a not a binary, exe for example, it will display this message
'This is a binary file. The content cannot be displayed.' This also
fixes problems where if the same commit with a binary is upload
multiple times the backend would hard fail. Now it returns without
doing anything.
Walked through a standard review process: posted changes,
interact with changes, commented, and posted changes. Also
covered by previouse tests written for image review UI.
Summary | ID |
---|---|
cce36a415102bebecc26af8669378b2747212328 | |
39e05b50ef7f8ff2e758f83cfc282d4e820f0dab | |
bb8bf7fbaa1c845b22044320c34aaf7797866003 | |
ad1c108f3969d54da1abf31e8f507a54c4dd14fc | |
921855571820bd43a761197d2c8742390127ae5d |
Description | From | Last Updated |
---|---|---|
Since there isn't any unit tests for these changes, it would be helpful if listed the testing that you did … |
|
|
The title of the review request should also be more descriptive (it should be a complete sentence). I think there … |
|
|
E501 line too long (97 > 79 characters) |
![]() |
|
E501 line too long (102 > 79 characters) |
![]() |
|
E722 do not use bare except' |
![]() |
|
E501 line too long (103 > 79 characters) |
![]() |
|
E501 line too long (103 > 79 characters) |
![]() |
|
Col: 55 Expected ')' to match '(' from line 381 and instead saw 's'. |
![]() |
|
Col: 56 Expected '{' and instead saw '.'. |
![]() |
|
Col: 56 Expected an identifier and instead saw '.'. |
![]() |
|
Col: 56 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 57 Missing semicolon. |
![]() |
|
Col: 79 Missing semicolon. |
![]() |
|
Col: 79 Expected an identifier and instead saw ')'. |
![]() |
|
Col: 79 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 80 Missing semicolon. |
![]() |
|
Col: 27 Expected an identifier and instead saw 'else'. |
![]() |
|
Col: 27 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 31 Missing semicolon. |
![]() |
|
E501 line too long (103 > 79 characters) |
![]() |
|
Col: 55 Expected ')' to match '(' from line 381 and instead saw 's'. |
![]() |
|
Col: 56 Expected '{' and instead saw '.'. |
![]() |
|
Col: 56 Expected an identifier and instead saw '.'. |
![]() |
|
Col: 56 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 57 Missing semicolon. |
![]() |
|
Col: 79 Missing semicolon. |
![]() |
|
Col: 79 Expected an identifier and instead saw ')'. |
![]() |
|
Col: 79 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 80 Missing semicolon. |
![]() |
|
Col: 27 Expected an identifier and instead saw 'else'. |
![]() |
|
Col: 27 Expected an assignment or function call and instead saw an expression. |
![]() |
|
Col: 31 Missing semicolon. |
![]() |
|
This will block non-image review UIs, which will brick 3rd party extensions. |
|
|
Since orig_review_ui is a local variable that does not actually get used by the returned renderer, it may make more … |
|
|
Same thing as the above comment |
|
|
$container.eq(0).html(xhr.responseText) |
|
reviewboard/attachments/managers.py (Diff revision 1) |
---|
reviewboard/webapi/resources/draft_filediff.py (Diff revision 1) |
---|
E501 line too long (103 > 79 characters)
Summary: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||
Commits: |
|
|||||||
Diff: |
Revision 2 (+16 -22) |
reviewboard/webapi/resources/draft_filediff.py (Diff revision 2) |
---|
E501 line too long (103 > 79 characters)
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+19 -23) |
Commits: |
|
|||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+5911 -5899) |
reviewboard/webapi/resources/draft_filediff.py (Diff revision 4) |
---|
E501 line too long (103 > 79 characters)
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 55 Expected ')' to match '(' from line 381 and instead saw 's'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 56 Expected '{' and instead saw '.'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 56 Expected an identifier and instead saw '.'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 56 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 57 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 79 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 79 Expected an identifier and instead saw ')'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 79 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 80 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 27 Expected an identifier and instead saw 'else'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 27 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 4) |
---|
Col: 31 Missing semicolon.
Commits: |
|
|||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+5916 -5902) |
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 55 Expected ')' to match '(' from line 381 and instead saw 's'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 56 Expected '{' and instead saw '.'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 56 Expected an identifier and instead saw '.'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 56 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 57 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 79 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 79 Expected an identifier and instead saw ')'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 79 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 80 Missing semicolon.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 27 Expected an identifier and instead saw 'else'.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 27 Expected an assignment or function call and instead saw an expression.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 5) |
---|
Col: 31 Missing semicolon.
Commits: |
|
|||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+11595 -11615) |
Since there isn't any unit tests for these changes, it would be helpful if listed the testing that you did for this review request as well.
reviewboard/reviews/views.py (Diff revision 6) |
---|
Since orig_review_ui is a local variable that does not actually get used by the returned renderer, it may make more sense to move this if statement to the beginning of this block
The title of the review request should also be more descriptive (it should be a complete sentence). I think there was a page on notion that discusses this but I can't remember what it is, but you can look at recent review requests that have landed for an example.
Each line in the description should be no more than 72 characters as well.
reviewboard/reviews/views.py (Diff revision 6) |
---|
This will block non-image review UIs, which will brick 3rd party extensions.
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js (Diff revision 6) |
---|
$container.eq(0).html(xhr.responseText)
Description: |
|
---|
Commits: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 7 (+11592 -11620) |