Fix binary diff rendering.
Review Request #10766 — Created Oct. 26, 2019 and discarded — Latest diff uploaded
Follows up on previous binary file changes. This will allow the
frontend to render binary files for visual reviewing. This will
only display a diff if the binary file is a image. If the file is
a not a binary, exe for example, it will display this message
'This is a binary file. The content cannot be displayed.' This also
fixes problems where if the same commit with a binary is upload
multiple times the backend would hard fail. Now it returns without
doing anything.
Walked through a standard review process: posted changes,
interact with changes, commented, and posted changes. Also
covered by previouse tests written for image review UI.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.
Commits
reviewboard/attachments/forms.py |
---|
reviewboard/reviews/views.py |
---|
reviewboard/webapi/resources/draft_filediff.py |
---|