WIP: Dynamic Review UI Rendering

Review Request #10758 — Created Oct. 20, 2019 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

Overview:

Add in functionality to allow review UIs to provide a list of (relative) URLs they want to register, along with the methods that will be handling requests to those URLs.

Task specifications can be found here

This task has been separated into 4 subtasks:

1. Base(1): Review UI URLs - Adding the ability for a ReviewUI subclass to provide URLs they want to make available. Assigned to Nicole.
2. Text(1): Built-In Render URLs - Adding a standard _render/ URL for TextBasedReviewUI. This would ultimately take a type= argument specifying (source or rendered), which could be passed by the caller. Assigned to Nicole.
3. Text(2): Rendering Options Template Block - Update reviewboard/templates/reviews/ui/text.html template to provide a {% block "render_options" %} that subclasses of the template can use to add new UI. This would be blank by default, meaning it's entirely optional, and can be used only by the review UIs that need it. Assigned to Adil.
4. Text(3): Render Requests in JavaScript - Wrap RB.apiCall in a new method to provide Review UIs with the ability to make requests for custom rendering options and backend rendering implementations. Assigned to Adil

Adil's Testing for Tasks 3 and 4:

  1. Ran JavaScript unit tests.
  2. Tested manually to make sure that the element to update actually gets
    updated by using a mock endpoint.
  3. Tested manually to make sure comments are correctly reattached after
    a request is finished.

Diff Revision 12 (Latest)

orig
1
2
3
4
5
6
7
8
9
10
11
12

Commits

First Last Summary ID Author
set up base for review ui urls
8321ecb908f20b49eb2268770c82695e3369ddb0 nicolelisa
add testing and fix patterns
db70ed57fcd4ad6e53ed9d7d60050b3fd55334c9 nicolelisa
reviewbot changes
e11c287f2f0ee9d18dbb15b0d8b7a92adb78b025 nicolelisa
wip for url rendering with ajax started
9b5766e66ce9613b4aae5a0c7c3466bdb5edba0d nicolelisa
revert html changes to rendering
ac92785154c3b11ffca422967cc093a3196da6e8 nicolelisa
reviewbot changes
bbac6f795332fbebc83b8392ecc3213b86f58ab2 nicolelisa
Add in Adil's 'Added function to reload render options with AJAX' - Review Re...
179716bc369fae4f98b62ebd30ef2f858e87f974 nicolelisa
reviewbot changes
cfebbba9ebc36d2fad99b5d2f88844892a0ec284 nicolelisa
Changed enpoint for ajax request to point to TextBasedReviewUIView url
20b38c6b129876ce9714e3a13672182c88fa8866 nicolelisa
Renamed TextBasedReviewUIView to TextBasedReviewUITextView
fad657c963f5bdf9b98f38eaa802fa033591c203 nicolelisa
Added in Review Request #10731 changes completed by Adil
b2bef6b73d110507856bf81618e48a846ccc79ec nicolelisa
Add dummy features for the Ajax functionality
8db350412c01e143b1d21654493f7667b80ea218 nicolelisa
reviewboard/deprecation.py
reviewboard/admin/urls.py
reviewboard/reviews/urls.py
reviewboard/reviews/views.py
reviewboard/reviews/views_mixins.py
reviewboard/reviews/tests/test_file_attachment_review_ui.py
reviewboard/reviews/ui/base.py
reviewboard/reviews/ui/markdownui.py
reviewboard/reviews/ui/text.py
reviewboard/static/rb/css/common.less
reviewboard/static/rb/css/pages/text-review-ui.less
reviewboard/static/rb/js/views/abstractReviewableView.es6.js
reviewboard/static/rb/js/views/markdownReviewableView.es6.js
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
reviewboard/static/rb/js/views/textCommentRowSelector.es6.js
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js
reviewboard/templates/reviews/ui/_text_table.html
reviewboard/templates/reviews/ui/markdown.html
reviewboard/templates/reviews/ui/text.html
Loading...