flake8
failed.
JSHint
passed.
Added function to reload render options with AJAX.
Review Request #10749 — Created Oct. 9, 2019 and updated
Individual review UIs that have dynamic render options can call this function,
and optionally pass in extra query parameters to send to the endpoint.More details can be found here
- Ran JavaScript unit tests.
- Tested manually to make sure that the element to update actually gets
updated by using a mock endpoint.- Tested manually to make sure comments are correctly reattached after
a request is finished.
| Summary | ID | Author |
|---|---|---|
| 622063c15356c6789049d605b14a324a2620cb61 | amalik2 |
| Description | From | Last Updated |
|---|---|---|
|
This also depends on the endpoint that will serve up the contents of the tables, so for now there's some … |
 amalik2
|
|
|
E302 expected 2 blank lines, found 1 |
 reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Col: 24 ['$el'] is better written in dot notation. |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
New CSS should follow this guide |
 brennie
|
|
|
You can use regular function statements here. |
brennie
|
|
|
Leftover testing code? |
brennie
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 6 Unnecessary semicolon. |
reviewbot
|
|
|
Col: 6 Unnecessary semicolon. |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
- Commits:
-
Summary ID Author de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 - Diff:
-
Revision 2 (+444 -4)
- Summary:
-
WIP: Added function to reload render options with AJAX.Added function to reload render options with AJAX.
- Description:
-
~ Still need to reload comments when a table gets updated
~ Individual review UIs that have dynamic render options can call this function,
+ and optionally pass in extra query parameters to send to the endpoint. + + More details can be found here
- Testing Done:
-
- Ran JavaScript unit tests.
- Tested manually to make sure that the element to update actually gets
updated by using a mock endpoint.
+ - Tested manually to make sure comments are correctly reattached after
a request is finished.
- Commits:
-
Summary ID Author de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 - Diff:
-
Revision 3 (+575 -27)
- Commits:
-
Summary ID Author de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 d688e87cf14065ca3cef0696450ea18ae0e8b997 amalik2 - Depends On:
-
- Diff:
Revision 4 (+587 -31)
- Commits:
-
Summary ID Author de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 d688e87cf14065ca3cef0696450ea18ae0e8b997 amalik2 de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 d688e87cf14065ca3cef0696450ea18ae0e8b997 amalik2 efb9fa409083f274c6567fb5e6ad5af5fe0f9236 amalik2 - Diff:
-
Revision 5 (+600 -38)
- Commits:
-
Summary ID Author de8ed5aeb30cd699133e15665c0b3150535cdab0 amalik2 3672c0404f978dde39a7fd79baaf6fb830158dae amalik2 2eb65bbfa849ddd375d6631fba360140be0aa553 amalik2 9149bc199a9f35044bd9b22ac54ac61382ca0542 amalik2 fb65d69fc2aff7dc97af9eec073d7d0c765adbfd amalik2 d688e87cf14065ca3cef0696450ea18ae0e8b997 amalik2 efb9fa409083f274c6567fb5e6ad5af5fe0f9236 amalik2 519bb71474bf32be0d0cc31e15aed8cb312e24ba amalik2 - Diff:
-
Revision 6 (+566 -4)
- Commits:
-
Summary ID Author 519bb71474bf32be0d0cc31e15aed8cb312e24ba amalik2 ed125289f5e7224a7f2ed6ecd47a4d1feba34190 amalik2 - Diff:
-
Revision 7 (+584 -4)
- Commits:
-
Summary ID Author ed125289f5e7224a7f2ed6ecd47a4d1feba34190 amalik2 622063c15356c6789049d605b14a324a2620cb61 amalik2 - Diff:
-
Revision 8 (+364 -4)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.