Return binary flag when with filediffs and allow querying by the binary flag.

 






 

 


  Review Request #10729
  —
  Created Sept. 26, 2019 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  perplex
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
RB Tools required getting the binary status of each filediff so it 

could determine which files need an accompanying file upload. This 

allows RB Tools to query the backend for the filediffs for a diff. The

filediffs returned will contain the binart flag. An optional flag is

also provide for querying only for filediffs that have the binary flag

set to either true or false.

 








  


 
 

  
Included unit test for these changes.

 







 









 





  








 




 







   

    
    
Diff Revision 8 (Latest)



    

 

 

 

 
orig
1
2
3
4
5
6
7
8

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Address David's comments

   
  		
  2cb39d374b5799e821a07e734ed6a614904bf64c
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
Fix grammar mistake

   
  		
  4b1e111fed1df7c8cd8ae27b89c8f7b1f9dec0b5
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    

     Revert "Fix grammar mistake"
     
This reverts commit 4b1e111fed1df7c8cd8ae27b89c8f7b1f9dec0b5.

    

   
  		
  9ae87d7ca6a8c5bad33d32df78baae77f8abde4b
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
Fix grammar

   
  		
  2371a6a041e2ca4c3c9147b85eac56039872fea2
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
Add binary filter test

   
  		
  46a4cabcc5cf318a5fefe46ebb5b98b5789628b2
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
replace double quotes with single quotes

   
  		
  9da99cd37e3d89ecd9ea02bd65a4ff646ae5a9c2
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
Use djblets to map query value to parameter

   
  		
  90b4f57a8285cd9be9d847410144002529972775
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
Add binary parameter to function description

   
  		
  3047b4be526f39ded08bf118b14930d5252f3b79
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
drop get_queryset parameters done one line

   
  		
  bd8db61615a5ce70d82438900eb6dff63a7c105d
  Ceegan Hale
 


 
  
   
  
  
   
  
 
 
  
   
    
format get_queryset description to fit line length limit

   
  		
  0cea0271d77078b30ee22e45bbb1356d111b7dbb
  Ceegan Hale
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/attachments/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/attachments/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/views.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/testing/testcase.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/draft_filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_filediff.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...