Return binary flag when with filediffs amd allow querying by the binary flag.

Review Request #10729 — Created Sept. 26, 2019 and updated

perplex
Review Board
master
reviewboard, students

RB Tools required getting the binary status of each filediff so it could determine which files need an accompanying file upload. This allows RB Tools to query the backend for the filediffs for a diff. The filediffs returned will contain the binart flag. An optional flag is also provide for querying only for filediffs that have the binary flag set to either true or false.



Summary
Address David's comments
Description From Last Updated

Can you flesh out the description and testing done? See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

daviddavid

Let's keep these in alphabetical order

daviddavid

This needs a period at the end.

daviddavid

Please use single quotes rather than double.

daviddavid

This can be simplified down to: qs = qs.filter(binary=(param == 'true'))

daviddavid
david
  1. 
      
  2. Can you flesh out the description and testing done? See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

  3. reviewboard/webapi/resources/filediff.py (Diff revision 1)
     
     
     
     
     
     

    Let's keep these in alphabetical order

  4. This needs a period at the end.

  5. reviewboard/webapi/resources/filediff.py (Diff revision 1)
     
     
     

    Please use single quotes rather than double.

  6. reviewboard/webapi/resources/filediff.py (Diff revision 1)
     
     
     
     
     

    This can be simplified down to:

    qs = qs.filter(binary=(param == 'true'))
    
  7. 
      
PE
PE
Review request changed

Description:

~  

Backend support for RB Tools to know which binary files it needs to upload with a diff.

  ~

RB Tools required getting the binary status of each filediff so it could determine which files need an accompanying file upload. This allows RB Tools to query the backend for the filediffs for a diff. The filediffs returned will contain the binart flag. An optional flag is also provide for querying only for filediffs that have the binary flag set to either true or false.

Loading...