WIP: Adding binary file support to RBTools.

Review Request #10720 — Created Sept. 21, 2019 and updated

perplex
RBTools
master
rbtools, students

Currently binary files are not attached to a diff for viewing in a code review. This hopes to allow binary files, such as images, to be added to diffs as file attachments so that reviewers can visually see the difference between two binaries.



Summary
WIP: Adding binary file support to RBTools.
Description From Last Updated

E501 line too long (145 > 79 characters)

reviewbotreviewbot

F401 'rbtools.utils.checks.format_diff_lines' imported but unused

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

F401 'rbtools.utils.checks.format_diff_lines' imported but unused

reviewbotreviewbot

F841 local variable 'is_binary' is assigned to but never used

reviewbotreviewbot

F841 local variable 'is_binary' is assigned to but never used

reviewbotreviewbot

F401 'rbtools.utils.checks.format_diff_lines' imported but unused

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E501 line too long (170 > 79 characters)

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Loading...