Summary

WIP: Adding binary file support to RBTools.

Review Request #10720 — Created Sept. 21, 2019 and discarded Nov. 10, 2019, 1:13 p.m.

Information

Owner

perplex

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools, students

People

Description

Currently binary files are not attached to a diff for viewing in a code review. This hopes to allow binary files, such as images, to be added to diffs as file attachments so that reviewers can visually see the difference between two binaries.

Testing Done

Commits

Summary	ID
WIP: Adding binary file support to RBTools.	39989aaeaa7deaa077563ef9412c19f53557b57a

Issues

Description	From	Last Updated
E501 line too long (145 > 79 characters)	reviewbot	Sept. 21, 2019, 4:59 p.m.
F401 'rbtools.utils.checks.format_diff_lines' imported but unused	reviewbot	Sept. 21, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 21, 2019, 4:59 p.m.
F401 'rbtools.utils.checks.format_diff_lines' imported but unused	reviewbot	Sept. 21, 2019, 4:59 p.m.
F841 local variable 'is_binary' is assigned to but never used	reviewbot	Sept. 21, 2019, 4:59 p.m.
F841 local variable 'is_binary' is assigned to but never used	reviewbot	Sept. 21, 2019, 4:59 p.m.
F401 'rbtools.utils.checks.format_diff_lines' imported but unused	reviewbot	Sept. 21, 2019, 4:59 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Sept. 21, 2019, 4:59 p.m.
E501 line too long (170 > 79 characters)	reviewbot	Sept. 21, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 21, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 21, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 21, 2019, 4:59 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 21, 2019, 4:59 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (145 > 79 characters)
```
rbtools/clients/bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'rbtools.utils.checks.format_diff_lines' imported but unused
```
rbtools/clients/bazaar.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
rbtools/clients/git.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'rbtools.utils.checks.format_diff_lines' imported but unused
```
rbtools/clients/git.py (Diff revision 1)
An issue was opened. Show all issues
```
F841 local variable 'is_binary' is assigned to but never used
```
rbtools/clients/git.py (Diff revision 1)
An issue was opened. Show all issues
```
F841 local variable 'is_binary' is assigned to but never used
```
rbtools/clients/perforce.py (Diff revision 1)
An issue was opened. Show all issues
```
F401 'rbtools.utils.checks.format_diff_lines' imported but unused
```
rbtools/clients/perforce.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (88 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (170 > 79 characters)
```
rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```
rbtools/commands/post.py (Diff revision 1)
An issue was opened. Show all issues
```
E265 block comment should start with '# '
```

Status:: Discarded

rbtools/api/resource.py (Diff revision 1)

rbtools/clients/bazaar.py (Diff revision 1)

rbtools/clients/bazaar.py (Diff revision 1)

rbtools/clients/git.py (Diff revision 1)