Added support for a Jupyter Notebooks rendered view.

Review Request #10719 — Created Sept. 21, 2019 and updated

amalik2
Review Board
master
reviewboard, students

There is also support for a difference viewer that highlights cells in
the notebook that were modified/added/deleted.

Conversion from the notebooks file to HTML is done by the nbconvert library:
https://github.com/jupyter/nbconvert

1) I ran unit tests with Python2.7 and Python3.6
2) I tested viewing a file normally with both Python2.7 and Python3.6
3) I tested viewing revisions of a file in the difference viewer with both
Python2.7 and Python 3.6

Summary Author
Added Jupyter Notebooks rendered view.
amalik2
fixed reviewbot errors
amalik2
Loading file attachments...

Description From Last Updated

F401 'json' imported but unused

reviewbotreviewbot

F401 'djblets.markdown.iter_markdown_lines' imported but unused

reviewbotreviewbot

F401 'reviewboard.reviews.chunk_generators.MarkdownDiffChunkGenerator' imported but unused

reviewbotreviewbot

F401 'reviewboard.reviews.markdown_utils.render_markdown_from_file' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name '_'

reviewbotreviewbot

F401 'json' imported but unused

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

amalik2
  1. 
      
  2. notebooks.css (Diff revision 1)
     
     

    Ignore this entire file, it's not used anywhere and I'll delete it later

  3. 
      
amalik2
Review request changed

Description:

~  

Still need to work on the difference chunks

  ~

Need to write unit tests and fix the preview thumbnail not showing up

Commits:

Summary Author
-
wrapping
amalik2
-
rendering works
amalik2
+
wrapping
amalik2
+
fixed diff chunks
amalik2
+
rendering works
amalik2

Diff:

Revision 2 (+25615 -13029)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amalik2
amalik2
Review request changed

Summary:

-WIP: Added support for Jupyter Notebooks difference viewer.
+Added support for a Jupyter Notebooks rendered view.

Description:

~  

Need to write unit tests and fix the preview thumbnail not showing up

  ~

There is also support for a difference viewer that highlights cells in

  + the notebook that were modified/added/deleted.

  +
  +

Conversion from the notebooks file to HTML is done by the nbconvert library:

  + https://github.com/jupyter/nbconvert

Testing Done:

  +

1) I ran unit tests with Python2.7 and Python3.6

  + 2) I tested viewing a file normally with both Python2.7 and Python3.6
  + 3) I tested viewing revisions of a file in the difference viewer with both
  + Python2.7 and Python 3.6

Commits:

Summary Author
-
wrapping
amalik2
-
fixed diff chunks
amalik2
-
rendering works
amalik2
-
fixed reviewbot errors
amalik2
+
Added Jupyter Notebooks rendered view.
amalik2

Diff:

Revision 4 (+714)

Show changes

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amalik2
Review request changed

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...