Summary

Added support for a Jupyter Notebooks rendered view.

Review Request #10719 — Created Sept. 21, 2019 and discarded Nov. 10, 2019, 1:54 p.m.

Information

Owner

amalik2

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

There is also support for a difference viewer that highlights cells in
the notebook that were modified/added/deleted.

Conversion from the notebooks file to HTML is done by the nbconvert library:
https://github.com/jupyter/nbconvert

Testing Done

1) I ran unit tests with Python2.7 and Python3.6
2) I tested viewing a file normally with both Python2.7 and Python3.6
3) I tested viewing revisions of a file in the difference viewer with both
Python2.7 and Python 3.6

Commits

Summary	ID	Author
Added Jupyter Notebooks rendered view.	0333213f9249fbff95ecb3dfc48c5ad48e9df8b2	amalik2
fixed reviewbot errors	896acc26a10e070cbddb508030d2990ffaa5f793	amalik2

Files

Issues

Description	From	Last Updated
F401 'json' imported but unused	reviewbot	Sept. 23, 2019, 5:27 p.m.
F401 'djblets.markdown.iter_markdown_lines' imported but unused	reviewbot	Sept. 23, 2019, 5:27 p.m.
F401 'reviewboard.reviews.chunk_generators.MarkdownDiffChunkGenerator' imported but unused	reviewbot	Sept. 23, 2019, 5:27 p.m.
F401 'reviewboard.reviews.markdown_utils.render_markdown_from_file' imported but unused	reviewbot	Sept. 23, 2019, 5:27 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 23, 2019, 5:31 p.m.
E265 block comment should start with '# '	reviewbot	Sept. 23, 2019, 5:27 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Sept. 23, 2019, 5:31 p.m.
F821 undefined name '_'	reviewbot	Sept. 23, 2019, 5:31 p.m.
F401 'json' imported but unused	reviewbot	Sept. 29, 2019, 2:40 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 29, 2019, 2:41 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 29, 2019, 2:41 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Sept. 29, 2019, 2:41 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 29, 2019, 2:41 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/jupyterui.py (Diff revision 1)
Show all issues
```
F401 'json' imported but unused
```

reviewboard/reviews/ui/jupyterui.py (Diff revision 1)

Show all issues

F401 'djblets.markdown.iter_markdown_lines' imported but unused

reviewboard/reviews/ui/jupyterui.py (Diff revision 1)

Show all issues

F401 'reviewboard.reviews.chunk_generators.MarkdownDiffChunkGenerator' imported but unused

reviewboard/reviews/ui/jupyterui.py (Diff revision 1)

Show all issues

F401 'reviewboard.reviews.markdown_utils.render_markdown_from_file' imported but unused

reviewboard/reviews/ui/jupyterui.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/ui/jupyterui.py (Diff revision 1)
Show all issues
```
E265 block comment should start with '# '
```

notebooks.css (Diff revision 1)

Ignore this entire file, it's not used anywhere and I'll delete it later

Description:

~		Still need to work on the difference chunks
	~	Need to write unit tests and fix the preview thumbnail not showing up

Commits:

Summary	ID	Author
rendering works	5dc296e8c240239a936d3a3f82f99f480086091b	amalik2
wrapping	44205313a6f45a963c261f7f92e3d347aae36ba4	amalik2
rendering works	5dc296e8c240239a936d3a3f82f99f480086091b	amalik2
wrapping	44205313a6f45a963c261f7f92e3d347aae36ba4	amalik2
fixed diff chunks	570f15ae67475720a7803e5b030c58aaabf0e7bf	amalik2

Diff:

Revision 2 (+25615 -13029)

Show changes

	test.ipynb
	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/jupyterui.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/ui/jupyterui.py (Diff revision 2)
Show all issues
```
F821 undefined name '_'
```

Commits:

Summary	ID	Author
rendering works	5dc296e8c240239a936d3a3f82f99f480086091b	amalik2
wrapping	44205313a6f45a963c261f7f92e3d347aae36ba4	amalik2
fixed diff chunks	570f15ae67475720a7803e5b030c58aaabf0e7bf	amalik2
rendering works	5dc296e8c240239a936d3a3f82f99f480086091b	amalik2
wrapping	44205313a6f45a963c261f7f92e3d347aae36ba4	amalik2
fixed diff chunks	570f15ae67475720a7803e5b030c58aaabf0e7bf	amalik2
fixed reviewbot errors	bfce9d2715c306f67abde0f7f85da63efa79d3e5	amalik2

Diff:

Revision 3 (+25619 -13029)

Show changes

	test.ipynb
	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	WIP: Added support for Jupyter Notebooks difference viewer.
+	Added support for a Jupyter Notebooks rendered view.

Description:

~		Need to write unit tests and fix the preview thumbnail not showing up
	~	There is also support for a difference viewer that highlights cells in
	+	the notebook that were modified/added/deleted.
	+
	+	Conversion from the notebooks file to HTML is done by the nbconvert library:
	+	https://github.com/jupyter/nbconvert

Testing Done:

	+	1) I ran unit tests with Python2.7 and Python3.6
	+	2) I tested viewing a file normally with both Python2.7 and Python3.6
	+	3) I tested viewing revisions of a file in the difference viewer with both
	+	Python2.7 and Python 3.6

Commits:

Summary	ID	Author
rendering works	5dc296e8c240239a936d3a3f82f99f480086091b	amalik2
wrapping	44205313a6f45a963c261f7f92e3d347aae36ba4	amalik2
fixed diff chunks	570f15ae67475720a7803e5b030c58aaabf0e7bf	amalik2
fixed reviewbot errors	bfce9d2715c306f67abde0f7f85da63efa79d3e5	amalik2
Added Jupyter Notebooks rendered view.	0333213f9249fbff95ecb3dfc48c5ad48e9df8b2	amalik2

Diff:

Revision 4 (+714)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/attachments/mimetypes.py
	reviewboard/reviews/tests/test_jupyter_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 4)
Show all issues
```
F401 'json' imported but unused
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 4)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/tests/test_jupyter_review_ui.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/reviews/ui/jupyterui.py (Diff revision 4)
Show all issues
```
W293 blank line contains whitespace
```

Commits:

Summary	ID	Author
Added Jupyter Notebooks rendered view.	0333213f9249fbff95ecb3dfc48c5ad48e9df8b2	amalik2
Added Jupyter Notebooks rendered view.	0333213f9249fbff95ecb3dfc48c5ad48e9df8b2	amalik2
fixed reviewbot errors	896acc26a10e070cbddb508030d2990ffaa5f793	amalik2

Diff:

Revision 5 (+719 -9)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/attachments/mimetypes.py
	reviewboard/reviews/tests/test_jupyter_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jupyterui.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jupyterReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Discarded

Change Summary:

Replaced by https://reviews.reviewboard.org/r/10761/