Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
Added support for a Jupyter Notebooks rendered view.
Review Request #10719 — Created Sept. 21, 2019 and discarded
There is also support for a difference viewer that highlights cells in
the notebook that were modified/added/deleted.Conversion from the notebooks file to HTML is done by the nbconvert library:
https://github.com/jupyter/nbconvert
1) I ran unit tests with Python2.7 and Python3.6
2) I tested viewing a file normally with both Python2.7 and Python3.6
3) I tested viewing revisions of a file in the difference viewer with both
Python2.7 and Python 3.6
| Summary | ID | Author |
|---|---|---|
| 0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 | amalik2 | |
| 896acc26a10e070cbddb508030d2990ffaa5f793 | amalik2 |
| Description | From | Last Updated |
|---|---|---|
|
F401 'json' imported but unused |
reviewbot
|
|
|
F401 'djblets.markdown.iter_markdown_lines' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.reviews.chunk_generators.MarkdownDiffChunkGenerator' imported but unused |
reviewbot
|
|
|
F401 'reviewboard.reviews.markdown_utils.render_markdown_from_file' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E265 block comment should start with '# ' |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
F821 undefined name '_' |
reviewbot
|
|
|
F401 'json' imported but unused |
reviewbot
|
|
|
E127 continuation line over-indented for visual indent |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
Review request changed
- Description:
-
~ Still need to work on the difference chunks
~ Need to write unit tests and fix the preview thumbnail not showing up
- Commits:
-
Summary ID Author 5dc296e8c240239a936d3a3f82f99f480086091b amalik2 44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2 5dc296e8c240239a936d3a3f82f99f480086091b amalik2 44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2 570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2
Review request changed
- Commits:
-
Summary ID Author 5dc296e8c240239a936d3a3f82f99f480086091b amalik2 44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2 570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2 5dc296e8c240239a936d3a3f82f99f480086091b amalik2 44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2 570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2 bfce9d2715c306f67abde0f7f85da63efa79d3e5 amalik2
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Review request changed
- Summary:
-
WIP: Added support for Jupyter Notebooks difference viewer.Added support for a Jupyter Notebooks rendered view.
- Description:
-
~ Need to write unit tests and fix the preview thumbnail not showing up
~ There is also support for a difference viewer that highlights cells in
+ the notebook that were modified/added/deleted. + + Conversion from the notebooks file to HTML is done by the nbconvert library:
+ https://github.com/jupyter/nbconvert - Testing Done:
-
+ 1) I ran unit tests with Python2.7 and Python3.6
+ 2) I tested viewing a file normally with both Python2.7 and Python3.6 + 3) I tested viewing revisions of a file in the difference viewer with both + Python2.7 and Python 3.6 - Commits:
-
Summary ID Author 5dc296e8c240239a936d3a3f82f99f480086091b amalik2 44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2 570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2 bfce9d2715c306f67abde0f7f85da63efa79d3e5 amalik2 0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 amalik2 - Diff:
-
Revision 4 (+714)
- Added Files:
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
Review request changed
- Commits:
-
Summary ID Author 0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 amalik2 0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 amalik2 896acc26a10e070cbddb508030d2990ffaa5f793 amalik2 - Diff:
-
Revision 5 (+719 -9)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.