Added support for a Jupyter Notebooks rendered view.

Review Request #10719 — Created Sept. 21, 2019 and discarded

Information

Review Board
master

Reviewers

There is also support for a difference viewer that highlights cells in
the notebook that were modified/added/deleted.

Conversion from the notebooks file to HTML is done by the nbconvert library:
https://github.com/jupyter/nbconvert

1) I ran unit tests with Python2.7 and Python3.6
2) I tested viewing a file normally with both Python2.7 and Python3.6
3) I tested viewing revisions of a file in the difference viewer with both
Python2.7 and Python 3.6

Summary ID Author
Added Jupyter Notebooks rendered view.
0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 amalik2
fixed reviewbot errors
896acc26a10e070cbddb508030d2990ffaa5f793 amalik2

Description From Last Updated

F401 'json' imported but unused

reviewbotreviewbot

F401 'djblets.markdown.iter_markdown_lines' imported but unused

reviewbotreviewbot

F401 'reviewboard.reviews.chunk_generators.MarkdownDiffChunkGenerator' imported but unused

reviewbotreviewbot

F401 'reviewboard.reviews.markdown_utils.render_markdown_from_file' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

F821 undefined name '_'

reviewbotreviewbot

F401 'json' imported but unused

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

amalik2
  1. 
      
  2. notebooks.css (Diff revision 1)
     
     

    Ignore this entire file, it's not used anywhere and I'll delete it later

  3. 
      
amalik2
Review request changed
Description:
~  

Still need to work on the difference chunks

  ~

Need to write unit tests and fix the preview thumbnail not showing up

Commits:
Summary ID Author
rendering works
5dc296e8c240239a936d3a3f82f99f480086091b amalik2
wrapping
44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2
rendering works
5dc296e8c240239a936d3a3f82f99f480086091b amalik2
wrapping
44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2
fixed diff chunks
570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amalik2
amalik2
Review request changed
Summary:
WIP: Added support for Jupyter Notebooks difference viewer.
Added support for a Jupyter Notebooks rendered view.
Description:
~  

Need to write unit tests and fix the preview thumbnail not showing up

  ~

There is also support for a difference viewer that highlights cells in

  + the notebook that were modified/added/deleted.

  +
  +

Conversion from the notebooks file to HTML is done by the nbconvert library:

  + https://github.com/jupyter/nbconvert

Testing Done:
  +

1) I ran unit tests with Python2.7 and Python3.6

  + 2) I tested viewing a file normally with both Python2.7 and Python3.6
  + 3) I tested viewing revisions of a file in the difference viewer with both
  + Python2.7 and Python 3.6

Commits:
Summary ID Author
rendering works
5dc296e8c240239a936d3a3f82f99f480086091b amalik2
wrapping
44205313a6f45a963c261f7f92e3d347aae36ba4 amalik2
fixed diff chunks
570f15ae67475720a7803e5b030c58aaabf0e7bf amalik2
fixed reviewbot errors
bfce9d2715c306f67abde0f7f85da63efa79d3e5 amalik2
Added Jupyter Notebooks rendered view.
0333213f9249fbff95ecb3dfc48c5ad48e9df8b2 amalik2
Added Files:

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amalik2
amalik2
Review request changed
Status:
Discarded
Change Summary:

Replaced by https://reviews.reviewboard.org/r/10761/