Review UI for JSON files

 






 

 


  Review Request #10716
  —
  Created Sept. 13, 2019 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  nicolelisa
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
Create a prettified JSON rendered version and a custom Review UI for JSON files.

 








  


 
 

  

 







 









 





  








 




 







   

    
    
Changes between revision 11 and 12



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
add test json data

   
  		
  53b7ac8f5688c3fe3efaa270e7d924ee2ef26ff6
  nicolelisa
 


 
  
 
 
  
   
    
modified json file

   
  		
  6a2394880a868f7cbf92e3ea65c4132d34f6ac11
  nicolelisa
 


 
  
 
 
  
   
    
jsonui file created

   
  		
  1efa4ef808c3cbc66f73780657e16e9962f6a764
  nicolelisa
 


 
  
 
 
  
   
    
create json specific page

   
  		
  a2d5c2dc8a52a2a3285724f3614c0adb3af9a31f
  nicolelisa
 


 
  
 
 
  
   
    
Add JsonLexer

   
  		
  2e14e0e95f43dbf775fb5d9af969c7b56a89652e
  nicolelisa
 


 
  
 
 
  
   
    
Add prettified version of JSON files to rendered

   
  		
  9fdf3e00a79c019df3dbce99b7f90284c4142320
  nicolelisa
 


 
  
 
 
  
   
    
fix reviewbot changes and move supported mimetype

   
  		
  a1f582af7a35db5ae77795b8050bd2e2be987aca
  nicolelisa
 


 
  
 
 
  
   
    
Add error handling and make review suggestions

   
  		
  e01d17ed24a699577d3ec3619d5ed0bf40f6f6e6
  nicolelisa
 


 
  
 
 
  
   
    
mirrored checkbox structure

   
  		
  61e191c3427b67cef2b30aaab11ed1c6d8c56c33
  nicolelisa
 


 
  
 
 
  
   
    
json testing

   
  		
  b86b0e1713a13e2e3f5a44c9714cefcc06bf6f2f
  nicolelisa
 


 
  
 
 
  
   
    
add testing and fix issues with <pre> tag

   
  		
  c2af08ff6c81982919a7f59cf6fc17d16ff8fdac
  nicolelisa
 


 
  
 
 
  
   
    
fix issues found by reviewbot

   
  		
  7a62deaed181d3191745b6e1e10e0a063d4d1fc5
  nicolelisa
 


 
  
 
 
  
   
    
json ui functionality created: squashed commits

   
  		
  4902e455577db34ce9f1b2301adba949ca2b492f
  nicolelisa
 


 
  
 
 
  
   
    
add testing to jsonui.py

   
  		
  60548d031592e5e94da2081a59d83605d3d6abe0
  nicolelisa
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/jsonui.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/test.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/pages/text-review-ui.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/jsonRenderOptionsView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/jsonReviewableView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...