flake8
-
reviewboard/reviews/ui/jsonui.py (Diff revision 1) Show all issues -
reviewboard/reviews/ui/jsonui.py (Diff revision 1) F401 'reviewboard.diffviewer.chunk_generator.RawDiffChunkGenerator' imported but unused
-
-
-
-
-
-
Review Request #10716 — Created Sept. 13, 2019 and updated
Create a prettified JSON rendered version and a custom Review UI for JSON files.
Summary | ID | Author |
---|---|---|
4902e455577db34ce9f1b2301adba949ca2b492f | nicolelisa | |
60548d031592e5e94da2081a59d83605d3d6abe0 | nicolelisa |
Description | From | Last Updated |
---|---|---|
Can you upload screenshots of your review UI in the normal rendered JSON view, as well as in the diff … |
|
|
F401 'logging' imported but unused |
![]() |
|
F401 'reviewboard.diffviewer.chunk_generator.RawDiffChunkGenerator' imported but unused |
![]() |
|
E501 line too long (92 > 79 characters) |
![]() |
|
This should go in your Review UI. |
|
|
F821 undefined name 'force_bytes' |
![]() |
|
F821 undefined name 'force_bytes' |
![]() |
|
F821 undefined name 'force_bytes' |
![]() |
|
F821 undefined name 'force_bytes' |
![]() |
|
W292 no newline at end of file |
![]() |
|
This commented import should either be removed or uncommented |
|
|
You should handle invalid JSON being parsed. If the user uploads a JSON file that json.dumps is unable to process, … |
|
|
E501 line too long (80 > 79 characters) |
![]() |
|
Make sure to delete this file once you're finished testing. |
|
|
Make sure to revert all changes in this file once Christian's PR with the same changes is merged |
|
|
Can you upload an image of where this CSS rule is used, and how the UI differs when it isn't … |
|
|
E303 too many blank lines (3) |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E116 unexpected indentation (comment) |
![]() |
|
E501 line too long (147 > 79 characters) |
![]() |
|
E501 line too long (138 > 79 characters) |
![]() |
|
E501 line too long (80 > 79 characters) |
![]() |
|
E126 continuation line over-indented for hanging indent |
![]() |
reviewboard/reviews/ui/jsonui.py (Diff revision 1) |
---|
reviewboard/reviews/ui/jsonui.py (Diff revision 1) |
---|
F401 'reviewboard.diffviewer.chunk_generator.RawDiffChunkGenerator' imported but unused
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+292 -58) |
Can you upload screenshots of your review UI in the normal rendered JSON view, as well as in the diff viewer?
reviewboard/reviews/ui/jsonui.py (Diff revision 2) |
---|
This commented import should either be removed or uncommented
reviewboard/reviews/ui/jsonui.py (Diff revision 2) |
---|
You should handle invalid JSON being parsed. If the user uploads a JSON file that json.dumps is unable to process, it would be best to display an error message to the user indicating that their JSON is invalid. In the markdown UI file, the try/catch in the generate_render() function handled this purpose. You should follow that same pattern, and wrap your code with a try/catch block. In the catch clause, you can yield the error message, and that error message will be visible in the render view when a parsing error occurs.
reviewboard/reviews/ui/test.json (Diff revision 2) |
---|
Make sure to delete this file once you're finished testing.
reviewboard/reviews/ui/text.py (Diff revision 2) |
---|
Make sure to revert all changes in this file once Christian's PR with the same changes is merged
reviewboard/static/rb/css/pages/text-review-ui.less (Diff revision 2) |
---|
Can you upload an image of where this CSS rule is used, and how the UI differs when it isn't set?
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+292 -70) |
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+277 -67) |
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+415 -83) |
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+531 -83) |
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 7 (+873 -87) |
reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 7) |
---|
E127 continuation line over-indented for visual indent
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+869 -87) |
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 9 (+881 -87) |
reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 9) |
---|
E501 line too long (147 > 79 characters)
reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 9) |
---|
E501 line too long (138 > 79 characters)
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 10 (+1043 -157) |
reviewboard/reviews/ui/jsonui.py (Diff revision 10) |
---|
E126 continuation line over-indented for hanging indent
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 11 (+1045 -161) |
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 12 (+536) |
Summary: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|