Summary

Review UI for JSON files

Review Request #10716 — Created Sept. 13, 2019 and updated Dec. 3, 2019, 11 p.m.

Information

Owner

nicolelisa

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Create a prettified JSON rendered version and a custom Review UI for JSON files.

Testing Done

Commits

Summary	ID	Author
json ui functionality created: squashed commits	4902e455577db34ce9f1b2301adba949ca2b492f	nicolelisa
add testing to jsonui.py	60548d031592e5e94da2081a59d83605d3d6abe0	nicolelisa

Issues

Description	From	Last Updated
Can you upload screenshots of your review UI in the normal rendered JSON view, as well as in the diff …	amalik2	Sept. 14, 2019, 5:26 p.m.
F401 'logging' imported but unused	reviewbot	Sept. 13, 2019, 2:45 p.m.
F401 'reviewboard.diffviewer.chunk_generator.RawDiffChunkGenerator' imported but unused	reviewbot	Sept. 13, 2019, 2:45 p.m.
E501 line too long (92 > 79 characters)	reviewbot	Sept. 13, 2019, 2:46 p.m.
This should go in your Review UI.	brennie	Sept. 13, 2019, 2:54 p.m.
F821 undefined name 'force_bytes'	reviewbot	Sept. 13, 2019, 2:48 p.m.
F821 undefined name 'force_bytes'	reviewbot	Sept. 13, 2019, 2:48 p.m.
F821 undefined name 'force_bytes'	reviewbot	Sept. 13, 2019, 2:48 p.m.
F821 undefined name 'force_bytes'	reviewbot	Sept. 13, 2019, 2:48 p.m.
W292 no newline at end of file	reviewbot	Sept. 13, 2019, 2:49 p.m.
This commented import should either be removed or uncommented	amalik2	Sept. 14, 2019, 5:33 p.m.
You should handle invalid JSON being parsed. If the user uploads a JSON file that json.dumps is unable to process, …	amalik2	Sept. 21, 2019, 3:31 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Sept. 13, 2019, 3:01 p.m.
Make sure to delete this file once you're finished testing.	amalik2	Sept. 14, 2019, 5:32 p.m.
Make sure to revert all changes in this file once Christian's PR with the same changes is merged	amalik2	Sept. 14, 2019, 5:32 p.m.
Can you upload an image of where this CSS rule is used, and how the UI differs when it isn't …	amalik2	Sept. 14, 2019, 5:33 p.m.
E303 too many blank lines (3)	reviewbot	Sept. 29, 2019, 12:13 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Sept. 29, 2019, 12:13 p.m.
E116 unexpected indentation (comment)	reviewbot	Sept. 29, 2019, 12:14 p.m.
E501 line too long (147 > 79 characters)	reviewbot	Oct. 12, 2019, 6:32 p.m.
E501 line too long (138 > 79 characters)	reviewbot	Oct. 12, 2019, 6:32 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Oct. 12, 2019, 6:35 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Oct. 12, 2019, 6:35 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/jsonui.py (Diff revision 1)
Show all issues
```
F401 'logging' imported but unused
```

reviewboard/reviews/ui/jsonui.py (Diff revision 1)

Show all issues

F401 'reviewboard.diffviewer.chunk_generator.RawDiffChunkGenerator' imported but unused

reviewboard/reviews/ui/jsonui.py (Diff revision 1)
Show all issues
```
E501 line too long (92 > 79 characters)
```
reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
F821 undefined name 'force_bytes'
```
reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
F821 undefined name 'force_bytes'
```
reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
F821 undefined name 'force_bytes'
```
reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
F821 undefined name 'force_bytes'
```
reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```

reviewboard/reviews/ui/text.py (Diff revision 1)
Show all issues
```
This should go in your Review UI.
```

Commits:

Summary	ID	Author
add test json data	a911b063b2091b7cd98fa3b852142915a006e562	nicolelisa
modified json file	b779a443c89b40b4680656133a66bc476fcd3c88	nicolelisa
jsonui file created	681c0fd63ccec568d6643182fdd58fcf40265510	nicolelisa
create json specific page	8a34f74b78d77bacde8b590586ade2ef5028059c	nicolelisa
Add JsonLexer	ed6af20d1999577a29a24e5a16bb7f4479266127	nicolelisa
Add prettified version of JSON files to rendered	d93362bac30bc18fdc385c72644eb4cc2f92d206	nicolelisa
add test json data	a911b063b2091b7cd98fa3b852142915a006e562	nicolelisa
modified json file	b779a443c89b40b4680656133a66bc476fcd3c88	nicolelisa
jsonui file created	681c0fd63ccec568d6643182fdd58fcf40265510	nicolelisa
create json specific page	8a34f74b78d77bacde8b590586ade2ef5028059c	nicolelisa
Add JsonLexer	ed6af20d1999577a29a24e5a16bb7f4479266127	nicolelisa
Add prettified version of JSON files to rendered	d93362bac30bc18fdc385c72644eb4cc2f92d206	nicolelisa
fix reviewbot changes and move supported mimetype	2b2ee52e5b953affb8babc80cc4ab36f683c9516	nicolelisa

Diff:

Revision 2 (+292 -58)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/views/jsonReviewableView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/jsonui.py (Diff revision 2)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Show all issues

Can you upload screenshots of your review UI in the normal rendered JSON view, as well as in the diff viewer?

nicolelisa Sept. 14, 2019, 5:26 p.m.

Sure. I'm not sure the best way to upload them but here are some dropbox links:

https://www.dropbox.com/s/q0ecf3jqtipn0nm/Screen%20Shot%202019-09-14%20at%206.22.35%20PM.png?dl=0
https://www.dropbox.com/s/qn4yz42rkpntfpj/Screen%20Shot%202019-09-14%20at%206.22.56%20PM.png?dl=0
https://www.dropbox.com/s/pcwxrzvqfppwn08/Screen%20Shot%202019-09-14%20at%206.23.27%20PM.png?dl=0

Note that one of them has an issue with whitespace, which should be a fairly easy fix next week.

reviewboard/reviews/ui/jsonui.py (Diff revision 2)

Show all issues

This commented import should either be removed or uncommented

nicolelisa Sept. 14, 2019, 5:44 p.m.

Uncommenting it gives an error with the Review bot, but I kept it there as a TODO since the markdown version has it.

reviewboard/reviews/ui/jsonui.py (Diff revision 2)

Show all issues

You should handle invalid JSON being parsed. If the user uploads a JSON file that json.dumps is unable to process, it would be best to display an error message to the user indicating that their JSON is invalid. In the markdown UI file, the try/catch in the generate_render() function handled this purpose. You should follow that same pattern, and wrap your code with a try/catch block. In the catch clause, you can yield the error message, and that error message will be visible in the render view when a parsing error occurs.

nicolelisa Sept. 14, 2019, 5:44 p.m.

Sounds good! Will put this on my list for next week.

reviewboard/reviews/ui/test.json (Diff revision 2)
Show all issues
```
Make sure to delete this file once you're finished testing.
```
1. nicolelisa Sept. 14, 2019, 5:44 p.m.
  Made a note of this.

reviewboard/reviews/ui/text.py (Diff revision 2)

Show all issues

Make sure to revert all changes in this file once Christian's PR with the same changes is merged

nicolelisa Sept. 14, 2019, 5:44 p.m.
```
Made a note of this.
```

reviewboard/static/rb/css/pages/text-review-ui.less (Diff revision 2)

Show all issues

Can you upload an image of where this CSS rule is used, and how the UI differs when it isn't set?

nicolelisa Sept. 14, 2019, 5:44 p.m.

This is in the above screenshots. The screenshot has it removed, but when it is added, the diff files stop working,
so I'm figuring out a way to differentiate them in CSS to prevent this.

Commits:

Summary	ID	Author
add test json data	a911b063b2091b7cd98fa3b852142915a006e562	nicolelisa
modified json file	b779a443c89b40b4680656133a66bc476fcd3c88	nicolelisa
jsonui file created	681c0fd63ccec568d6643182fdd58fcf40265510	nicolelisa
create json specific page	8a34f74b78d77bacde8b590586ade2ef5028059c	nicolelisa
Add JsonLexer	ed6af20d1999577a29a24e5a16bb7f4479266127	nicolelisa
Add prettified version of JSON files to rendered	d93362bac30bc18fdc385c72644eb4cc2f92d206	nicolelisa
fix reviewbot changes and move supported mimetype	2b2ee52e5b953affb8babc80cc4ab36f683c9516	nicolelisa
add test json data	a911b063b2091b7cd98fa3b852142915a006e562	nicolelisa
modified json file	b779a443c89b40b4680656133a66bc476fcd3c88	nicolelisa
jsonui file created	681c0fd63ccec568d6643182fdd58fcf40265510	nicolelisa
create json specific page	8a34f74b78d77bacde8b590586ade2ef5028059c	nicolelisa
Add JsonLexer	ed6af20d1999577a29a24e5a16bb7f4479266127	nicolelisa
Add prettified version of JSON files to rendered	d93362bac30bc18fdc385c72644eb4cc2f92d206	nicolelisa
fix reviewbot changes and move supported mimetype	2b2ee52e5b953affb8babc80cc4ab36f683c9516	nicolelisa
make changes as per Adil's recommendations	995b853ce3d6ae2f1f987cba61ca802af57f629d	nicolelisa

Diff:

Revision 3 (+292 -70)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/js/views/jsonReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
add test json data	a911b063b2091b7cd98fa3b852142915a006e562	nicolelisa
modified json file	b779a443c89b40b4680656133a66bc476fcd3c88	nicolelisa
jsonui file created	681c0fd63ccec568d6643182fdd58fcf40265510	nicolelisa
create json specific page	8a34f74b78d77bacde8b590586ade2ef5028059c	nicolelisa
Add JsonLexer	ed6af20d1999577a29a24e5a16bb7f4479266127	nicolelisa
Add prettified version of JSON files to rendered	d93362bac30bc18fdc385c72644eb4cc2f92d206	nicolelisa
fix reviewbot changes and move supported mimetype	2b2ee52e5b953affb8babc80cc4ab36f683c9516	nicolelisa
make changes as per Adil's recommendations	995b853ce3d6ae2f1f987cba61ca802af57f629d	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa

Diff:

Revision 4 (+277 -67)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/js/views/jsonReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	c45235513c64e981a8975798330e75d7565a1dfc	nicolelisa

Diff:

Revision 5 (+415 -83)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.js
	reviewboard/static/rb/js/views/jsonReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	c45235513c64e981a8975798330e75d7565a1dfc	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa

Diff:

Revision 6 (+531 -83)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/scmtools/testdata/hg_repo/.hg/wcache/checkisexec
	reviewboard/scmtools/testdata/hg_repo/.hg/wcache/checknoexec
	reviewboard/static/rb/css/pages/text-review-ui.less
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Review UI for JSON files - WIP
+	WIP: Review UI for JSON files

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	37fc47024f5810f58d509d1b764c57f7e18f1c72	nicolelisa

Diff:

Revision 7 (+873 -87)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
	2 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 7)
Show all issues
```
E303 too many blank lines (3)
```
reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 7)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/reviews/ui/jsonui.py (Diff revision 7)
Show all issues
```
E116 unexpected indentation (comment)
```

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	37fc47024f5810f58d509d1b764c57f7e18f1c72	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	8b59fe2b4920c1776af77304d0a0e49c40fcf1ad	nicolelisa

Diff:

Revision 8 (+869 -87)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	8b59fe2b4920c1776af77304d0a0e49c40fcf1ad	nicolelisa
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	38f1e834099efeb290f7cde48e437f994dd0c91b	nicolelisa

Diff:

Revision 9 (+881 -87)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/reviews/ui/text.py
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
	2 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 9)
Show all issues
```
E501 line too long (147 > 79 characters)
```
reviewboard/reviews/tests/test_json_review_ui.py (Diff revision 9)
Show all issues
```
E501 line too long (138 > 79 characters)
```

Commits:

Summary	ID	Author
add test json data	525f146eeaf2c87768cb832f4bcd7fa90d6d622a	nicolelisa
modified json file	55b3e8a7e15653f2b679ff41eb0795fcb6e654f8	nicolelisa
jsonui file created	cbd4262bc517a427c4846d72804d1847c8d2559c	nicolelisa
create json specific page	cc57a6f030109ca9f5beb988d93d59e1a36cea96	nicolelisa
Add JsonLexer	f813e9ca16f3463a156c8ceab92088051ec158a2	nicolelisa
Add prettified version of JSON files to rendered	3844b6180b6ca9bb24d3f85c36733e447771e93a	nicolelisa
fix reviewbot changes and move supported mimetype	02de0e02bb76744ef1cfb737d34c320b2ab902c0	nicolelisa
Add error handling and make review suggestions	b75b7170e7b937f0934a9081fd01a6f2e5f478d9	nicolelisa
mirrored checkbox structure	5cc736b51aac899ba629e485453a1a81dcae69e1	nicolelisa
json testing	38f1e834099efeb290f7cde48e437f994dd0c91b	nicolelisa
add test json data	53b7ac8f5688c3fe3efaa270e7d924ee2ef26ff6	nicolelisa
modified json file	6a2394880a868f7cbf92e3ea65c4132d34f6ac11	nicolelisa
jsonui file created	1efa4ef808c3cbc66f73780657e16e9962f6a764	nicolelisa
create json specific page	a2d5c2dc8a52a2a3285724f3614c0adb3af9a31f	nicolelisa
Add JsonLexer	2e14e0e95f43dbf775fb5d9af969c7b56a89652e	nicolelisa
Add prettified version of JSON files to rendered	9fdf3e00a79c019df3dbce99b7f90284c4142320	nicolelisa
fix reviewbot changes and move supported mimetype	a1f582af7a35db5ae77795b8050bd2e2be987aca	nicolelisa
Add error handling and make review suggestions	e01d17ed24a699577d3ec3619d5ed0bf40f6f6e6	nicolelisa
mirrored checkbox structure	61e191c3427b67cef2b30aaab11ed1c6d8c56c33	nicolelisa
json testing	b86b0e1713a13e2e3f5a44c9714cefcc06bf6f2f	nicolelisa
add testing and fix issues with <pre> tag	c2af08ff6c81982919a7f59cf6fc17d16ff8fdac	nicolelisa
fix issues found by reviewbot	6cdb46b8ef4c03b4f99f4c82fd7275d7c47d785c	nicolelisa

Diff:

Revision 10 (+1043 -157)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
	reviewboard/static/rb/js/views/jsonRenderOptionsView.es6.js
	1 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/jsonui.py (Diff revision 10)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/ui/jsonui.py (Diff revision 10)
Show all issues
```
E126 continuation line over-indented for hanging indent
```

Commits:

Summary	ID	Author
add test json data	53b7ac8f5688c3fe3efaa270e7d924ee2ef26ff6	nicolelisa
modified json file	6a2394880a868f7cbf92e3ea65c4132d34f6ac11	nicolelisa
jsonui file created	1efa4ef808c3cbc66f73780657e16e9962f6a764	nicolelisa
create json specific page	a2d5c2dc8a52a2a3285724f3614c0adb3af9a31f	nicolelisa
Add JsonLexer	2e14e0e95f43dbf775fb5d9af969c7b56a89652e	nicolelisa
Add prettified version of JSON files to rendered	9fdf3e00a79c019df3dbce99b7f90284c4142320	nicolelisa
fix reviewbot changes and move supported mimetype	a1f582af7a35db5ae77795b8050bd2e2be987aca	nicolelisa
Add error handling and make review suggestions	e01d17ed24a699577d3ec3619d5ed0bf40f6f6e6	nicolelisa
mirrored checkbox structure	61e191c3427b67cef2b30aaab11ed1c6d8c56c33	nicolelisa
json testing	b86b0e1713a13e2e3f5a44c9714cefcc06bf6f2f	nicolelisa
add testing and fix issues with <pre> tag	c2af08ff6c81982919a7f59cf6fc17d16ff8fdac	nicolelisa
fix issues found by reviewbot	6cdb46b8ef4c03b4f99f4c82fd7275d7c47d785c	nicolelisa
add test json data	53b7ac8f5688c3fe3efaa270e7d924ee2ef26ff6	nicolelisa
modified json file	6a2394880a868f7cbf92e3ea65c4132d34f6ac11	nicolelisa
jsonui file created	1efa4ef808c3cbc66f73780657e16e9962f6a764	nicolelisa
create json specific page	a2d5c2dc8a52a2a3285724f3614c0adb3af9a31f	nicolelisa
Add JsonLexer	2e14e0e95f43dbf775fb5d9af969c7b56a89652e	nicolelisa
Add prettified version of JSON files to rendered	9fdf3e00a79c019df3dbce99b7f90284c4142320	nicolelisa
fix reviewbot changes and move supported mimetype	a1f582af7a35db5ae77795b8050bd2e2be987aca	nicolelisa
Add error handling and make review suggestions	e01d17ed24a699577d3ec3619d5ed0bf40f6f6e6	nicolelisa
mirrored checkbox structure	61e191c3427b67cef2b30aaab11ed1c6d8c56c33	nicolelisa
json testing	b86b0e1713a13e2e3f5a44c9714cefcc06bf6f2f	nicolelisa
add testing and fix issues with <pre> tag	c2af08ff6c81982919a7f59cf6fc17d16ff8fdac	nicolelisa
fix issues found by reviewbot	7a62deaed181d3191745b6e1e10e0a063d4d1fc5	nicolelisa

Diff:

Revision 11 (+1045 -161)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/reviews/ui/test.json
	reviewboard/static/rb/css/pages/text-review-ui.less
	reviewboard/static/rb/js/models/jsonBasedReviewableModel.es6.js
	reviewboard/static/rb/js/views/jsonRenderOptionsView.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

Summary	ID	Author
add test json data	53b7ac8f5688c3fe3efaa270e7d924ee2ef26ff6	nicolelisa
modified json file	6a2394880a868f7cbf92e3ea65c4132d34f6ac11	nicolelisa
jsonui file created	1efa4ef808c3cbc66f73780657e16e9962f6a764	nicolelisa
create json specific page	a2d5c2dc8a52a2a3285724f3614c0adb3af9a31f	nicolelisa
Add JsonLexer	2e14e0e95f43dbf775fb5d9af969c7b56a89652e	nicolelisa
Add prettified version of JSON files to rendered	9fdf3e00a79c019df3dbce99b7f90284c4142320	nicolelisa
fix reviewbot changes and move supported mimetype	a1f582af7a35db5ae77795b8050bd2e2be987aca	nicolelisa
Add error handling and make review suggestions	e01d17ed24a699577d3ec3619d5ed0bf40f6f6e6	nicolelisa
mirrored checkbox structure	61e191c3427b67cef2b30aaab11ed1c6d8c56c33	nicolelisa
json testing	b86b0e1713a13e2e3f5a44c9714cefcc06bf6f2f	nicolelisa
add testing and fix issues with <pre> tag	c2af08ff6c81982919a7f59cf6fc17d16ff8fdac	nicolelisa
fix issues found by reviewbot	7a62deaed181d3191745b6e1e10e0a063d4d1fc5	nicolelisa
json ui functionality created: squashed commits	4902e455577db34ce9f1b2301adba949ca2b492f	nicolelisa
add testing to jsonui.py	60548d031592e5e94da2081a59d83605d3d6abe0	nicolelisa

Diff:

Revision 12 (+536)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/tests/test_json_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/jsonui.py
	reviewboard/static/rb/js/views/jsonReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	WIP: Review UI for JSON files
+	Review UI for JSON files

Description:

~		modified json file
	~	Create a prettified JSON rendered version and a custom Review UI for JSON files.
-		jsonui file created
-		create json specific page
-		Add JsonLexer
-		Add prettified version of JSON files to rendered
-
-		Currently an issue with diff for file attachments.