Summary

Update relatedUserSelectorViewTests.es6.js to use the new avatar rendering mechanism.

Review Request #10703 — Created Sept. 7, 2019 and submitted Sept. 8, 2019, 9:35 a.m.

Information

Owner

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

116fc8e...

Reviewers

Groups

People

Description

This test was not updated to use the new avatar rendering support recently
added to Djblets, which was causing this test to fail. This patch updates
the test.

Testing Done

This test was run locally, and now passes.

Issues

Description	From	Last Updated
Can you move this to release-4.0.x? Those same tests are broken there.	david	Sept. 8, 2019, 9:23 a.m.
Col: 17 Expected an assignment or function call and instead saw an expression.	reviewbot	Sept. 7, 2019, 3:35 p.m.
Col: 30 Missing semicolon.	reviewbot	Sept. 7, 2019, 3:35 p.m.
Col: 30 Expected '}' to match '{' from line 1 and instead saw ':'.	reviewbot	Sept. 7, 2019, 3:36 p.m.
Col: 32 Expected ')' and instead saw '{'.	reviewbot	Sept. 7, 2019, 3:36 p.m.
Col: 33 Missing semicolon.	reviewbot	Sept. 7, 2019, 3:36 p.m.
Col: 21 Expected an assignment or function call and instead saw an expression.	reviewbot	Sept. 7, 2019, 3:36 p.m.
Col: 25 Missing semicolon.	reviewbot	Sept. 7, 2019, 3:36 p.m.
Col: 21 Unrecoverable syntax error. (28% scanned).	reviewbot	Sept. 7, 2019, 3:36 p.m.
We prefer single quotes over double.	david	Sept. 8, 2019, 8:11 a.m.
This should have a trailing comma.	david	Sept. 8, 2019, 8:12 a.m.
Single quotes.	david	Sept. 8, 2019, 8:12 a.m.
The key should have single quotes, and there should be a trailing comma here.	david	Sept. 8, 2019, 8:12 a.m.
Single quotes here too.	david	Sept. 8, 2019, 8:12 a.m.
The key should have single quotes, and there should be a trailing comma here.	david	Sept. 8, 2019, 8:12 a.m.
The key should have single quotes, and there should be a trailing comma here.	david	Sept. 8, 2019, 8:12 a.m.
The key should have single quotes, and there should be a trailing comma here.	david	Sept. 8, 2019, 8:12 a.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 17
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 30
 Missing semicolon.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 30
 Expected '}' to match '{' from line 1 and instead saw ':'.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 32
 Expected ')' and instead saw '{'.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 33
 Missing semicolon.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 21
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 25
 Missing semicolon.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 1)
Show all issues
```
Col: 21
 Unrecoverable syntax error. (28% scanned).
```

Commit:

-	9a0e17527998c57371e0c431d896e6e1496f4390
+	cf4495214e73f5d2b73beb4486c95110c7601dfb

Diff:

Revision 2 (+28 -9)

reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
We prefer single quotes over double.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
This should have a trailing comma.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
Single quotes.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
The key should have single quotes, and there should be a trailing comma here.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
Single quotes here too.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
The key should have single quotes, and there should be a trailing comma here.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
The key should have single quotes, and there should be a trailing comma here.
```
reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js (Diff revision 2)
Show all issues
```
The key should have single quotes, and there should be a trailing comma here.
```

Commit:

-	cf4495214e73f5d2b73beb4486c95110c7601dfb
+	9852ba64c6677de05102eceeb4bfc73390309131

Diff:

Revision 3 (+33 -14)

reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Show all issues

Can you move this to release-4.0.x? Those same tests are broken there.

Branch:

-	master
+	release-4.0.x

Commit:

-	9852ba64c6677de05102eceeb4bfc73390309131
+	116fc8ef4ee78706a6a60a6efddb5c09e99fb6a9

Diff:

Revision 4 (+33 -14)

reviewboard/static/rb/js/admin/tests/relatedUserSelectorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (78e661c)

Loading...