Update relatedUserSelectorViewTests.es6.js to use the new avatar rendering mechanism.

Review Request #10703 — Created Sept. 7, 2019 and submitted

Information

Review Board
release-4.0.x
116fc8e...

Reviewers

This test was not updated to use the new avatar rendering support recently
added to Djblets, which was causing this test to fail. This patch updates
the test.

This test was run locally, and now passes.

Description From Last Updated

Can you move this to release-4.0.x? Those same tests are broken there.

daviddavid

Col: 17 Expected an assignment or function call and instead saw an expression.

reviewbotreviewbot

Col: 30 Missing semicolon.

reviewbotreviewbot

Col: 30 Expected '}' to match '{' from line 1 and instead saw ':'.

reviewbotreviewbot

Col: 32 Expected ')' and instead saw '{'.

reviewbotreviewbot

Col: 33 Missing semicolon.

reviewbotreviewbot

Col: 21 Expected an assignment or function call and instead saw an expression.

reviewbotreviewbot

Col: 25 Missing semicolon.

reviewbotreviewbot

Col: 21 Unrecoverable syntax error. (28% scanned).

reviewbotreviewbot

We prefer single quotes over double.

daviddavid

This should have a trailing comma.

daviddavid

Single quotes.

daviddavid

The key should have single quotes, and there should be a trailing comma here.

daviddavid

Single quotes here too.

daviddavid

The key should have single quotes, and there should be a trailing comma here.

daviddavid

The key should have single quotes, and there should be a trailing comma here.

daviddavid

The key should have single quotes, and there should be a trailing comma here.

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

mike_conley
david
  1. 
      
  2. Show all issues

    We prefer single quotes over double.

  3. Show all issues

    This should have a trailing comma.

  4. Show all issues

    Single quotes.

  5. Show all issues

    The key should have single quotes, and there should be a trailing comma here.

  6. Show all issues

    Single quotes here too.

  7. Show all issues

    The key should have single quotes, and there should be a trailing comma here.

  8. Show all issues

    The key should have single quotes, and there should be a trailing comma here.

  9. Show all issues

    The key should have single quotes, and there should be a trailing comma here.

  10. 
      
mike_conley
david
  1. 
      
  2. Show all issues

    Can you move this to release-4.0.x? Those same tests are broken there.

  3. 
      
mike_conley
mike_conley
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (78e661c)