• 
      

    Update relatedUserSelectorViewTests.es6.js to use the new avatar rendering mechanism.

    Review Request #10703 — Created Sept. 7, 2019 and submitted

    Information

    Review Board
    release-4.0.x
    116fc8e...

    Reviewers

    This test was not updated to use the new avatar rendering support recently
    added to Djblets, which was causing this test to fail. This patch updates
    the test.

    This test was run locally, and now passes.

    Description From Last Updated

    Can you move this to release-4.0.x? Those same tests are broken there.

    david david

    Col: 17 Expected an assignment or function call and instead saw an expression.

    reviewbot reviewbot

    Col: 30 Missing semicolon.

    reviewbot reviewbot

    Col: 30 Expected '}' to match '{' from line 1 and instead saw ':'.

    reviewbot reviewbot

    Col: 32 Expected ')' and instead saw '{'.

    reviewbot reviewbot

    Col: 33 Missing semicolon.

    reviewbot reviewbot

    Col: 21 Expected an assignment or function call and instead saw an expression.

    reviewbot reviewbot

    Col: 25 Missing semicolon.

    reviewbot reviewbot

    Col: 21 Unrecoverable syntax error. (28% scanned).

    reviewbot reviewbot

    We prefer single quotes over double.

    david david

    This should have a trailing comma.

    david david

    Single quotes.

    david david

    The key should have single quotes, and there should be a trailing comma here.

    david david

    Single quotes here too.

    david david

    The key should have single quotes, and there should be a trailing comma here.

    david david

    The key should have single quotes, and there should be a trailing comma here.

    david david

    The key should have single quotes, and there should be a trailing comma here.

    david david
    Checks run (1 failed, 1 succeeded)
    flake8 passed.
    JSHint failed.

    JSHint

    mike_conley
    david
    1. 
        
    2. Show all issues

      We prefer single quotes over double.

    3. Show all issues

      This should have a trailing comma.

    4. Show all issues

      Single quotes.

    5. Show all issues

      The key should have single quotes, and there should be a trailing comma here.

    6. Show all issues

      Single quotes here too.

    7. Show all issues

      The key should have single quotes, and there should be a trailing comma here.

    8. Show all issues

      The key should have single quotes, and there should be a trailing comma here.

    9. Show all issues

      The key should have single quotes, and there should be a trailing comma here.

    10. 
        
    mike_conley
    david
    1. 
        
    2. Show all issues

      Can you move this to release-4.0.x? Those same tests are broken there.

    3. 
        
    mike_conley
    mike_conley
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (78e661c)