Fish Trophy

  
brennie got a fish trophy!

  
  Fish Trophy

 







 





 

 

  

  

 




  







 




  


 
 

  
Set the correct root URL in RB.TextBasedReviewableView

 






 

 


  Review Request #10701
  —
  Created Sept. 7, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10699
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The RB.TextBasedReviewableView was using an incorrect root path

Instead of just being the path relative to the FQDN, it was using the

entire URL. This resulted in Backbone never matching URLs since it was

trying to match fragments against full URLs. The view would then be

stuck in the rendered view mode at all times.

 








  


 
 

  
Verified that the TextBasedReviewableView can switch between rendered

and source modes on Python 2.7, 3.5, 3.6, and 3.7.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Set the correct root URL in RB.TextBasedReviewableView
     
The `RB.TextBasedReviewableView` was using an incorrect root path
Instead of just being the path relative to the FQDN, it was using the
entire URL. This resulted in Backbone never matching URLs since it was
trying to match fragments against full URLs. The view would then be
stuck in the rendered view mode at all times.

Testing done:
Verified that the TextBasedReviewableView can switch between rendered
and source modes on Python 2.7, 3.5, 3.6, and 3.7.

    

   
  		
  91e4b8a0a1eeaaed33174af8acca2993a034495e
  Barret Rennie
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...