brennie got a fish trophy!
Set the correct root URL in RB.TextBasedReviewableView
Review Request #10701 — Created Sept. 7, 2019 and submitted
The
RB.TextBasedReviewableView
was using an incorrect root path
Instead of just being the path relative to the FQDN, it was using the
entire URL. This resulted in Backbone never matching URLs since it was
trying to match fragments against full URLs. The view would then be
stuck in the rendered view mode at all times.
Verified that the TextBasedReviewableView can switch between rendered
and source modes on Python 2.7, 3.5, 3.6, and 3.7.
Summary | ID |
---|---|
f9faaaa2f8144b6c7f4f43ea4b9ed8bd6d53ee19 |
Description | From | Last Updated |
---|---|---|
Good opportunity to add a unit test :) |
chipx86 | |
Can you pull the this.model.get('fileAttachmentID') out into its own variable? I don't mind template literals but they're a lot easier … |
chipx86 | |
Col: 67 Missing semicolon. |
reviewbot | |
Col: 42 Missing semicolon. |
reviewbot | |
Col: 67 Missing semicolon. |
reviewbot | |
Col: 42 Missing semicolon. |
reviewbot | |
Just one blank line here. |
chipx86 |
-
-
-
reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 1) Can you pull the
this.model.get('fileAttachmentID')
out into its own variable? I don't mind template literals but they're a lot easier to read and manage if they're pretty limited in what they execute.
Change Summary:
more tests
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -2) |
Checks run (2 succeeded)
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+188 -2) |
Checks run (1 failed, 1 succeeded)
JSHint
-
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 3) Col: 67 Missing semicolon.
-
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 3) Col: 42 Missing semicolon.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+182 -2) |
Checks run (1 failed, 1 succeeded)
JSHint
-
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4) Col: 67 Missing semicolon.
-
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4) Col: 42 Missing semicolon.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+182 -2) |
Checks run (2 succeeded)
-
-
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5) Just one blank line here.