brennie got a fish trophy!

Summary

Set the correct root URL in RB.TextBasedReviewableView

Review Request #10701 — Created Sept. 7, 2019 and submitted Sept. 10, 2019, 1:20 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

master

Bugs

Depends On

~~10699~~

Reviewers

Groups

reviewboard

People

Description

The RB.TextBasedReviewableView was using an incorrect root path
Instead of just being the path relative to the FQDN, it was using the
entire URL. This resulted in Backbone never matching URLs since it was
trying to match fragments against full URLs. The view would then be
stuck in the rendered view mode at all times.

Testing Done

Verified that the TextBasedReviewableView can switch between rendered
and source modes on Python 2.7, 3.5, 3.6, and 3.7.

Commits

Summary	ID	Author
Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	f9faaaa2f8144b6c7f4f43ea4b9ed8bd6d53ee19	Barret Rennie

Issues

Description	From	Last Updated
Good opportunity to add a unit test :)	chipx86	Sept. 7, 2019, 3:53 p.m.
Can you pull the this.model.get('fileAttachmentID') out into its own variable? I don't mind template literals but they're a lot easier …	chipx86	Sept. 7, 2019, 3:53 p.m.
Col: 67 Missing semicolon.	reviewbot	Sept. 8, 2019, 8:06 a.m.
Col: 42 Missing semicolon.	reviewbot	Sept. 8, 2019, 8:06 a.m.
Col: 67 Missing semicolon.	reviewbot	Sept. 8, 2019, 8:06 a.m.
Col: 42 Missing semicolon.	reviewbot	Sept. 8, 2019, 8:06 a.m.
Just one blank line here.	chipx86	Sept. 10, 2019, 1:19 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues
```
Good opportunity to add a unit test :)
```

reviewboard/static/rb/js/views/textBasedReviewableView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Can you pull the this.model.get('fileAttachmentID') out into its own variable? I don't mind template literals but they're a lot easier to read and manage if they're pretty limited in what they execute.

Change Summary:

more tests

Commits:

	Summary	ID	Author
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7.	91e4b8a0a1eeaaed33174af8acca2993a034495e	Barret Rennie
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7.	de8ef0c32dfc2a996bdb53dd7dddf541340ea9c5	Barret Rennie

Diff:

Revision 2 (+4 -2)

Show changes

reviewboard/static/rb/js/views/textBasedReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID	Author
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7.	de8ef0c32dfc2a996bdb53dd7dddf541340ea9c5	Barret Rennie
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	7c8dade28968911259e28feec919e0e38b1b8818	Barret Rennie

Diff:

Revision 3 (+188 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 67
 Missing semicolon.
```
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 42
 Missing semicolon.
```

Commits:

	Summary	ID	Author
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	7c8dade28968911259e28feec919e0e38b1b8818	Barret Rennie
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	ab65dbf76fbecc62c5fef6849eccd3eeb81f94fd	Barret Rennie

Diff:

Revision 4 (+182 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 67
 Missing semicolon.
```
reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 42
 Missing semicolon.
```

Commits:

	Summary	ID	Author
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	ab65dbf76fbecc62c5fef6849eccd3eeb81f94fd	Barret Rennie
	Set the correct root URL in RB.TextBasedReviewableView The `RB.TextBasedReviewableView` was using an incorrect root path Instead of just being the path relative to the FQDN, it was using the entire URL. This resulted in Backbone never matching URLs since it was trying to match fragments against full URLs. The view would then be stuck in the rendered view mode at all times. Testing done: - Verified that the TextBasedReviewableView can switch between rendered and source modes on Python 2.7, 3.5, 3.6, and 3.7. - Ran JS tests.	f9faaaa2f8144b6c7f4f43ea4b9ed8bd6d53ee19	Barret Rennie

Diff:

Revision 5 (+182 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/textBasedReviewableView.es6.js
	reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/views/tests/textBasedReviewableViewTests.es6.js (Diff revision 5)

The issue has been resolved. Show all issues

Just one blank line here.

Status:: Completed
Change Summary:: Pushed to master (47444c9)