Use text types for HTTP methods

 






 

 


  Review Request #10695
  —
  Created Sept. 6, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  10685
 









 
 

  10696
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The DVCS-specific API resources were incorrectly using byte strings for

their method names. On Python 2, this would result in sending

HTTP POST, but on Python 3 we would send HTTP b'POST' and end up

getting HTTP 400 errors back. If we use the text type, it works on both

Python 2 and Python 3.

 








  


 
 

  
Confirmed the following on Python versions 2.7, 3.5, 3.6, and 3.7:


    

  • With this entire patch stack (/r/10685, /r/10696, and /r/10697),
    
rbt post is able to create review requests with commit history.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Use text types for HTTP methods
     
The DVCS-specific API resources were incorrectly using byte strings for
their method names. On Python 2, this would result in sending `HTTP
POST`, but on Python 3 we would send `HTTP b'POST'` and end up getting
HTTP 400 errors back. If we use the text type, it works on both Python 2
and Python 3.

Testing done:
Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7:
- With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt
  post` is able to create review requests with commit history.

    

   
  		
  6096450653c53f887390e2008f031ea91307e6fb
  Barret Rennie
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/api/resource.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...