Use text types for HTTP methods

Review Request #10695 — Created Sept. 6, 2019 and updated

brennie
RBTools
master
10685
10696
rbtools

The DVCS-specific API resources were incorrectly using byte strings for
their method names. On Python 2, this would result in sending
HTTP POST, but on Python 3 we would send HTTP b'POST' and end up
getting HTTP 400 errors back. If we use the text type, it works on both
Python 2 and Python 3.

Confirmed the following hold true on Python verisons 2.7, 3.5, 3.6,
and 3.7:

  • With this entire patch stack (/r/10685, /r/10696, and /r/10697),
    rbt post is able to create review requests with commit history.
Summary
Use text types for HTTP methods
Description From Last Updated

There's some weird wrapping taking place in the description and testing, due to trying to wrap within a literal.

chipx86chipx86

In Testing Done, looks like "hold" shouldn't be there?

chipx86chipx86
chipx86
  1. 
      
  2. There's some weird wrapping taking place in the description and testing, due to trying to wrap within a literal.

  3. In Testing Done, looks like "hold" shouldn't be there?

  4. 
      
brennie
Review request changed

Description:

   

The DVCS-specific API resources were incorrectly using byte strings for

~   their method names. On Python 2, this would result in sending HTTP
~   POST, but on Python 3 we would send HTTP b'POST' and end up getting
~   HTTP 400 errors back. If we use the text type, it works on both Python 2
~   and Python 3.

  ~ their method names. On Python 2, this would result in sending
  ~ HTTP POST, but on Python 3 we would send HTTP b'POST' and end up
  ~ getting HTTP 400 errors back. If we use the text type, it works on both
  ~ Python 2 and Python 3.

Testing Done:

~  

Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7:

~   - With this entire patch stack (/r/10685, /r/10696, and /r/10697), rbt
~   post is able to create review requests with commit history.

  ~

Confirmed the following hold true on Python verisons 2.7, 3.5, 3.6,

  ~ and 3.7:

  ~
  +
  • With this entire patch stack (/r/10685, /r/10696, and /r/10697),
    rbt post is able to create review requests with commit history.
Loading...