Summary

Use text types for HTTP methods

Review Request #10695 — Created Sept. 6, 2019 and submitted Jan. 7, 2020, 12:32 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

~~10685~~

Blocks

10696

Reviewers

Groups

rbtools

People

Description

The DVCS-specific API resources were incorrectly using byte strings for
their method names. On Python 2, this would result in sending
HTTP POST, but on Python 3 we would send HTTP b'POST' and end up
getting HTTP 400 errors back. If we use the text type, it works on both
Python 2 and Python 3.

Testing Done

Confirmed the following on Python versions 2.7, 3.5, 3.6, and 3.7:

With this entire patch stack (/r/10685, /r/10696, and /r/10697),
rbt post is able to create review requests with commit history.

Commits

Summary	ID
Use text types for HTTP methods The DVCS-specific API resources were incorrectly using byte strings for their method names. On Python 2, this would result in sending `HTTP POST`, but on Python 3 we would send `HTTP b'POST'` and end up getting HTTP 400 errors back. If we use the text type, it works on both Python 2 and Python 3. Testing done: Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7: - With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt post` is able to create review requests with commit history.	6096450653c53f887390e2008f031ea91307e6fb

Summary

Use text types for HTTP methods

The DVCS-specific API resources were incorrectly using byte strings for their method names. On Python 2, this would result in sending `HTTP POST`, but on Python 3 we would send `HTTP b'POST'` and end up getting HTTP 400 errors back. If we use the text type, it works on both Python 2 and Python 3. Testing done: Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7: - With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt post` is able to create review requests with commit history.

6096450653c53f887390e2008f031ea91307e6fb

Issues

Description	From	Last Updated
In Testing Done, looks like "hold" shouldn't be there?	chipx86	Sept. 10, 2019, 1:25 p.m.
There's some weird wrapping taking place in the description and testing, due to trying to wrap within a literal.	chipx86	Sept. 10, 2019, 1:25 p.m.
In "Testing Done", "Confirmed the following hold true" is still pretty weird phrasing. How about just "Confirmed the following on …	david	Sept. 27, 2019, 2:03 p.m.
Typo in testing done: verisons -> versions.	david	Sept. 27, 2019, 2:03 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

In Testing Done, looks like "hold" shouldn't be there?

The issue has been resolved. Show all issues

There's some weird wrapping taking place in the description and testing, due to trying to wrap within a literal.

Description:

		The DVCS-specific API resources were incorrectly using byte strings for
~		their method names. On Python 2, this would result in sending `HTTP`
~		POST, but on Python 3 we would send `HTTP b'POST'` and end up getting
~		HTTP 400 errors back. If we use the text type, it works on both Python 2
~		and Python 3.
	~	their method names. On Python 2, this would result in sending
	~	`HTTP POST`, but on Python 3 we would send `HTTP b'POST'` and end up
	~	getting HTTP 400 errors back. If we use the text type, it works on both
	~	Python 2 and Python 3.

Testing Done:

~		Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7:
~		- With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt`
~		post is able to create review requests with commit history.
	~	Confirmed the following hold true on Python verisons 2.7, 3.5, 3.6,
	~	and 3.7:
	~
	+	With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt post` is able to create review requests with commit history.

The issue has been resolved. Show all issues

In "Testing Done", "Confirmed the following hold true" is still pretty weird phrasing. How about just "Confirmed the following on Python versions ..."?

The issue has been resolved. Show all issues

Typo in testing done: verisons -> versions.

Testing Done:

~		Confirmed the following hold true on Python verisons 2.7, 3.5, 3.6,
	~	Confirmed the following on Python versions 2.7, 3.5, 3.6, and 3.7:
-		and 3.7:

		With this entire patch stack (/r/10685, /r/10696, and /r/10697), `rbt post` is able to create review requests with commit history.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1ce1dae)