flake8
passed.
JSHint
passed.
Use text types for HTTP methods
Review Request #10695 — Created Sept. 6, 2019 and submitted
The DVCS-specific API resources were incorrectly using byte strings for
their method names. On Python 2, this would result in sending
HTTP POST, but on Python 3 we would sendHTTP b'POST'and end up
getting HTTP 400 errors back. If we use the text type, it works on both
Python 2 and Python 3.
Confirmed the following on Python versions 2.7, 3.5, 3.6, and 3.7:
- With this entire patch stack (/r/10685, /r/10696, and /r/10697),
rbt postis able to create review requests with commit history.
| Summary | ID | Author |
|---|---|---|
| 6096450653c53f887390e2008f031ea91307e6fb | Barret Rennie |
| Description | From | Last Updated |
|---|---|---|
|
In Testing Done, looks like "hold" shouldn't be there? |
 chipx86
|
|
|
There's some weird wrapping taking place in the description and testing, due to trying to wrap within a literal. |
chipx86
|
|
|
In "Testing Done", "Confirmed the following hold true" is still pretty weird phrasing. How about just "Confirmed the following on … |
 david
|
|
|
Typo in testing done: verisons -> versions. |
david
|
- Description:
-
The DVCS-specific API resources were incorrectly using byte strings for
~ their method names. On Python 2, this would result in sending HTTP~ POST, but on Python 3 we would send HTTP b'POST'and end up getting~ HTTP 400 errors back. If we use the text type, it works on both Python 2 ~ and Python 3. ~ their method names. On Python 2, this would result in sending ~ HTTP POST, but on Python 3 we would sendHTTP b'POST'and end up~ getting HTTP 400 errors back. If we use the text type, it works on both ~ Python 2 and Python 3. - Testing Done:
-
~ Confirmed the following hold on Python verisons 2.7, 3.5, 3.6, and 3.7:
~ - With this entire patch stack (/r/10685, /r/10696, and /r/10697), rbt~ post is able to create review requests with commit history. ~ Confirmed the following hold true on Python verisons 2.7, 3.5, 3.6,
~ and 3.7: ~ + - With this entire patch stack (/r/10685, /r/10696, and /r/10697),
rbt postis able to create review requests with commit history.
- With this entire patch stack (/r/10685, /r/10696, and /r/10697),
