Summary:

Fixed news widget not refreshing when the refresh option is clicked.

Review Request #10694 — Created Sept. 6, 2019 and updated Sept. 7, 2019, 1:18 p.m.

Information
Owner:	amalik2
Repository:	Review Board
Branch:	master
Bugs:	4751
Depends On:
Reviewers
Groups:	reviewboard, students
People:

Description

In the HTML file where the onclick listener is attached, it tries to

attach it to an anchor tag with the class "reload-news". The actual

tag that is meant to handle refreshing the news widget has an id set

to "reload-news", rather than a class.
This changes that CSS selector to use the id, rather than the class.

Testing Done

Tested locally with console.log() and by adding a debugger statement to
the on click listener, and then clicking on the refresh news widget
item. This triggers an AJAX call, which is visible in the network tab.

Commits

Summary	Author
Fixed news widget refresh not working.	amalik2

Screenshots

Issues

Description	From	Last Updated
Can you wrap your description and testing done at 72 characters?	brennie	Sept. 7, 2019, 8:07 a.m.
The summary is too long. It must be one line and keep to <= 72 characters. You can simplify it …	chipx86	Sept. 7, 2019, 9:14 a.m.
We can get rid of the a bit. It's actually faster to look it up as a pure ID.	chipx86	Sept. 7, 2019, 9:14 a.m.

flake8 passed.

JSHint passed.

Show all issues

Can you wrap your description and testing done at 72 characters?

Description:

~		Fixed incorrect CSS selector being used to attach click handler for news widget refresh.
	~	Fixed incorrect CSS selector being used to attach click handler for
	+	news widget refresh.

~		In the HTML file where the onclick listener is attached, it tries to attach it to an anchor tag with the class "reload-news". The actual tag that is meant to handle refreshing the news widget has an id set to "reload-news", rather than a class.
	~	In the HTML file where the onclick listener is attached, it tries to
	+	attach it to an anchor tag with the class "reload-news". The actual
	+	tag that is meant to handle refreshing the news widget has an id set
	+	to "reload-news", rather than a class.

		This changes that CSS selector to use the id, rather than the class.

Testing Done:

~		Tested locally with console.log() and by adding a debugger statement to the on click listener, and then clicking on the refresh news widget item. This triggers an AJAX call, which is visible in the network tab.
	~	Tested locally with console.log() and by adding a debugger statement to
	+	the on click listener, and then clicking on the refresh news widget
	+	item. This triggers an AJAX call, which is visible in the network tab.

Show all issues

The summary is too long. It must be one line and keep to <= 72 characters. You can simplify it by leaving out the technical reason for the problem and focus on what you're fixing.

reviewboard/templates/admin/widgets/w-news.html (Diff revision 1)

Show all issues

We can get rid of the a bit. It's actually faster to look it up as a pure ID.

Summary:

-	Fixed incorrect CSS selector being used to attach click handler for news widget refresh.
+	Fixed news widget not refreshing when the refresh option is clicked.

Description:

~		Fixed incorrect CSS selector being used to attach click handler for
	~	Fixed news widget not refreshing when the refresh option is clicked.
-		news widget refresh.

		In the HTML file where the onclick listener is attached, it tries to
		attach it to an anchor tag with the class "reload-news". The actual
		tag that is meant to handle refreshing the news widget has an id set
		to "reload-news", rather than a class.

		This changes that CSS selector to use the id, rather than the class.

Description:

-		Fixed news widget not refreshing when the refresh option is clicked.
-
		In the HTML file where the onclick listener is attached, it tries to
		attach it to an anchor tag with the class "reload-news". The actual
		tag that is meant to handle refreshing the news widget has an id set
		to "reload-news", rather than a class.

		This changes that CSS selector to use the id, rather than the class.

Commits:

	Summary	Author
-	Fixed incorrect CSS selector being used to attach click handler for news widget refresh.	amalik2
+	Fixed news widget refresh not working.	amalik2

Diff:

Revision 2 (+2 -2)

Show changes

reviewboard/templates/admin/widgets/w-news.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```