Made it so tooltips do not add extra space to the bottom of the page.

Review Request #10693 — Created Sept. 6, 2019 and updated

amalik2
Djblets
master
4776
djblets, students

The tooltips are anchored to the element that caused them to be visible
in a way such that they end up adding extra space on to the bottom of
the page, which makes it so that part of the tooltip is not visible
when a comment is added to the very bottom line of the very last file
in the DiffViewer component. The user would need to scroll down to the
new bottom of the page in order to view the entirety of the tooltip.

This fix uses a flag for the tooltip positioning function that tells
the function to render the tooltip with a position that does not result
in extra space being added to the page.

I added in a comment at the very bottom line of the very last file in a
review request. The comment no longer adds space to the bottom of the
page.

I also added in another comment that was about halfway through the last
file in the review, just to make sure that comment's popup still gets
rendered the same way, since this change should not impact that case.

Summary Author
Made it so tooltips fit the screen instead of adding extra space to the bottom of the page.
amalik2
Description From Last Updated

Can you wrap your description and testing done at 72 characters?

brenniebrennie

The summary is too long. It should ideally be <= 72 characters. You can focus on the core fix in ...

chipx86chipx86
brennie
  1. Tiny nit, otherwise great :)

  2. Can you wrap your description and testing done at 72 characters?

  3. 
      
amalik2
brennie
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. The summary is too long. It should ideally be <= 72 characters. You can focus on the core fix in the summary. Something like:

    Make diff viewer comment tooltips always fit on the screen.

  3. 
      
amalik2
amalik2
Review request changed

Description:

-  

Made it so tooltips do not add extra space to the bottom of the page.

-  
   

The tooltips are anchored to the element that caused them to be visible

    in a way such that they end up adding extra space on to the bottom of
    the page, which makes it so that part of the tooltip is not visible
    when a comment is added to the very bottom line of the very last file
    in the DiffViewer component. The user would need to scroll down to the
    new bottom of the page in order to view the entirety of the tooltip.

   
   

   
   

This fix uses a flag for the tooltip positioning function that tells

    the function to render the tooltip with a position that does not result
    in extra space being added to the page.

Loading...