Summary

Made it so tooltips do not add extra space to the bottom of the page.

Review Request #10693 — Created Sept. 6, 2019 and updated Sept. 7, 2019, 9:14 a.m.

Information

Owner

amalik2

Repository

Djblets

Branch

master

Bugs

4776

Depends On

Reviewers

Groups

djblets, students

People

Description

The tooltips are anchored to the element that caused them to be visible

in a way such that they end up adding extra space on to the bottom of

the page, which makes it so that part of the tooltip is not visible

when a comment is added to the very bottom line of the very last file

in the DiffViewer component. The user would need to scroll down to the

new bottom of the page in order to view the entirety of the tooltip.

This fix uses a flag for the tooltip positioning function that tells

the function to render the tooltip with a position that does not result

in extra space being added to the page.

Testing Done

I added in a comment at the very bottom line of the very last file in a
review request. The comment no longer adds space to the bottom of the
page.

I also added in another comment that was about halfway through the last
file in the review, just to make sure that comment's popup still gets
rendered the same way, since this change should not impact that case.

Commits

Summary	ID	Author
Made it so tooltips fit the screen instead of adding extra space to the bottom of the page.	175f4aff710ad3f6f8f88df20e996cf1136d0ac9	amalik2

Issues

Description	From	Last Updated
Can you wrap your description and testing done at 72 characters?	brennie	Sept. 7, 2019, 8:09 a.m.
The summary is too long. It should ideally be <= 72 characters. You can focus on the core fix in …	chipx86	Sept. 7, 2019, 9:10 a.m.

flake8 passed.

JSHint passed.

```
Tiny nit, otherwise great :)
```

The issue has been resolved. Show all issues

Can you wrap your description and testing done at 72 characters?

Description:: ~
Made it so tooltips fit the screen instead of adding extra space to the bottom of the page.
~
Made it so tooltips fit the screen instead of adding extra space to the
+ bottom of the page.

~
The tooltips are anchored to the element that caused them to be visible in a way such that they end up adding extra space on to the bottom of the page, which makes it so that part of the tooltip is not visible when a comment is added to the very bottom line of the very last file in the DiffViewer component. The user would need to scroll down to the new bottom of the page in order to view the entirety of the tooltip.
~
The tooltips are anchored to the element that caused them to be visible
+ in a way such that they end up adding extra space on to the bottom of
+ the page, which makes it so that part of the tooltip is not visible
+ when a comment is added to the very bottom line of the very last file
+ in the DiffViewer component. The user would need to scroll down to the
+ new bottom of the page in order to view the entirety of the tooltip.

~
This fix uses a flag for the tooltip positioning function that tells the function to render the tooltip with a position that does not result in extra space being added to the page
~
+
+
This fix uses a flag for the tooltip positioning function that tells
+ the function to render the tooltip with a position that does not result
+ in extra space being added to the page.
Testing Done:: ~
I added in a comment at the very bottom line of the very last file in a review request. The comment no longer adds space to the bottom of the page.
~
I added in a comment at the very bottom line of the very last file in a
+ review request. The comment no longer adds space to the bottom of the
+ page.

~
I also added in another comment that was about halfway through the last file in the review, just to make sure that comment's popup still gets rendered the same way, since this change should not impact that case.
~
I also added in another comment that was about halfway through the last
+ file in the review, just to make sure that comment's popup still gets
+ rendered the same way, since this change should not impact that case.

Ship it!

```
Ship It!
```

Ship it! Fix it!

An issue was opened. Show all issues

The summary is too long. It should ideally be <= 72 characters. You can focus on the core fix in the summary. Something like:

Make diff viewer comment tooltips always fit on the screen.

Summary:: Made it so tooltips fit the screen instead of adding extra space to the bottom of the page.
Made it so tooltips do not add extra space to the bottom of the page.
Description:: ~
Made it so tooltips fit the screen instead of adding extra space to the
~
Made it so tooltips do not add extra space to the bottom of the page.
- bottom of the page.

The tooltips are anchored to the element that caused them to be visible
in a way such that they end up adding extra space on to the bottom of
the page, which makes it so that part of the tooltip is not visible
when a comment is added to the very bottom line of the very last file
in the DiffViewer component. The user would need to scroll down to the
new bottom of the page in order to view the entirety of the tooltip.

This fix uses a flag for the tooltip positioning function that tells
the function to render the tooltip with a position that does not result
in extra space being added to the page.

Description:: -
Made it so tooltips do not add extra space to the bottom of the page.
-

The tooltips are anchored to the element that caused them to be visible
in a way such that they end up adding extra space on to the bottom of
the page, which makes it so that part of the tooltip is not visible
when a comment is added to the very bottom line of the very last file
in the DiffViewer component. The user would need to scroll down to the
new bottom of the page in order to view the entirety of the tooltip.

This fix uses a flag for the tooltip positioning function that tells
the function to render the tooltip with a position that does not result
in extra space being added to the page.

~		Made it so tooltips fit the screen instead of adding extra space to the bottom of the page.
	~	Made it so tooltips fit the screen instead of adding extra space to the
	+	bottom of the page.

~		The tooltips are anchored to the element that caused them to be visible in a way such that they end up adding extra space on to the bottom of the page, which makes it so that part of the tooltip is not visible when a comment is added to the very bottom line of the very last file in the DiffViewer component. The user would need to scroll down to the new bottom of the page in order to view the entirety of the tooltip.
	~	The tooltips are anchored to the element that caused them to be visible
	+	in a way such that they end up adding extra space on to the bottom of
	+	the page, which makes it so that part of the tooltip is not visible
	+	when a comment is added to the very bottom line of the very last file
	+	in the DiffViewer component. The user would need to scroll down to the
	+	new bottom of the page in order to view the entirety of the tooltip.

~		This fix uses a flag for the tooltip positioning function that tells the function to render the tooltip with a position that does not result in extra space being added to the page
	~
	+
	+	This fix uses a flag for the tooltip positioning function that tells
	+	the function to render the tooltip with a position that does not result
	+	in extra space being added to the page.

~		I added in a comment at the very bottom line of the very last file in a review request. The comment no longer adds space to the bottom of the page.
	~	I added in a comment at the very bottom line of the very last file in a
	+	review request. The comment no longer adds space to the bottom of the
	+	page.

~		I also added in another comment that was about halfway through the last file in the review, just to make sure that comment's popup still gets rendered the same way, since this change should not impact that case.
	~	I also added in another comment that was about halfway through the last
	+	file in the review, just to make sure that comment's popup still gets
	+	rendered the same way, since this change should not impact that case.