Added bundle for djblets-integrations for running JavaScript unit tests.

Review Request #10688 — Created Sept. 6, 2019 and updated

amalik2
Review Board
master
reviewboard, students

When the JavaScript unit tests were run, the djblets-integration bundle
is never loaded. This leads to the djblets integration tests failing,
because they require that bundle in order to run correctly. This change
simply loads that bundle before unit tests are run.

I tested locally by hitting http://localhost:8080/js-tests/

Summary Author
Added bundle for djblets-integrations for running JavaScript unit tests.
amalik2
Description From Last Updated

We like to see a bit more information for review request descriptions, telling a story about the change. For instance, ...

chipx86chipx86

Can you wrap your description at 72 characters?

brenniebrennie

Very small nit: There's 2 blank lines between the summary and description, and there should only be one.

chipx86chipx86

Oh also, the summary is being repeated in the description. You can remove that. Same with your other changes, I ...

chipx86chipx86
chipx86
  1. 
      
  2. We like to see a bit more information for review request descriptions, telling a story about the change. For instance, we should be able to know from the review request description (and resulting commit message) what the problem was and how you fixed it.

    You can read through Writing Good Change Descriptions and other commits in the repository to see the style we like.

  3. 
      
amalik2
brennie
  1. Only a small nit. :)

  2. Can you wrap your description at 72 characters?

  3. 
      
amalik2
chipx86
  1. 
      
  2. Very small nit: There's 2 blank lines between the summary and description, and there should only be one.

  3. 
      
amalik2
chipx86
  1. 
      
  2. Oh also, the summary is being repeated in the description. You can remove that.

    Same with your other changes, I think.

  3. 
      
amalik2
Review request changed

Description:

-  

Added bundle for djblets-integrations for running JavaScript unit tests.

-  
   

When the JavaScript unit tests were run, the djblets-integration bundle

    is never loaded. This leads to the djblets integration tests failing,
    because they require that bundle in order to run correctly. This change
    simply loads that bundle before unit tests are run.

Loading...