Add the Mercurial test repository cache directory to .gitignore.

Review Request #10686 — Created Sept. 6, 2019 and submitted

Information

Review Board
master

Reviewers

When generating test data using manage.py fill-database,
the directory reviewboard/scmtools/testdata/hg_repo/.hg/wcache/
was being consistently generated. It was added to the .gitignore.


 
Summary ID Author
add a cache directory to gitignore
e58832c3fc094101c9da64ef85d7c0a60aa3ab62 nicolelisa
Description From Last Updated

Hi Nicole. Make sure the description follows our [guide] on commit messages. We like to see a kind of story …

chipx86chipx86

Your summary is included in your description. Please update the summary and remove the duplicate line from the description.

brenniebrennie

Can you wrap the remaining bit of your description at 72 characters?

brenniebrennie

Small suggestion for improvement. Since this is a Mercurial cache directory, that detail would he great to have in the …

chipx86chipx86
chipx86
  1. 
      
  2. Show all issues

    Hi Nicole.

    Make sure the description follows our [guide] on commit messages. We like to see a kind of story about the problem that this is solving and a high-level summary of how, and that should be descriptive enough without having to look at a line of code.

    There may not appear to be a big story for this change, but coming in without looking at the code, I don't know what cache directory this is referring to, meaning I will have to jump in and read it. Doesn't seem like a big deal, but it might be less obvious 3 years from now.

    Knowing which cache directory and where that comes from can be helpful.

    Also, as part of this, make sure there's sentence casing, and a Testing Done.

  3. 
      
nicolelisa
brennie
  1. 
      
  2. Show all issues

    Your summary is included in your description. Please update the summary and remove the duplicate line from the description.

  3. Show all issues

    Can you wrap the remaining bit of your description at 72 characters?

  4. 
      
nicolelisa
brennie
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    Small suggestion for improvement. Since this is a Mercurial cache directory, that detail would he great to have in the summary. How about:

    Add the Mercurial test repository cache directory to .gitignore.

  3. 
      
nicolelisa
david
  1. Ship It!
  2. 
      
nicolelisa
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (9652237)