flake8
passed.
JSHint
passed.
Add the Mercurial test repository cache directory to .gitignore.
Review Request #10686 — Created Sept. 6, 2019 and submitted
When generating test data using
manage.py fill-database,
the directoryreviewboard/scmtools/testdata/hg_repo/.hg/wcache/
was being consistently generated. It was added to the .gitignore.
| Summary | ID | Author |
|---|---|---|
| e58832c3fc094101c9da64ef85d7c0a60aa3ab62 | nicolelisa |
| Description | From | Last Updated |
|---|---|---|
|
Hi Nicole. Make sure the description follows our [guide] on commit messages. We like to see a kind of story … |
 chipx86
|
|
|
Your summary is included in your description. Please update the summary and remove the duplicate line from the description. |
 brennie
|
|
|
Can you wrap the remaining bit of your description at 72 characters? |
brennie
|
|
|
Small suggestion for improvement. Since this is a Mercurial cache directory, that detail would he great to have in the … |
chipx86
|
-
-
Hi Nicole.
Make sure the description follows our [guide] on commit messages. We like to see a kind of story about the problem that this is solving and a high-level summary of how, and that should be descriptive enough without having to look at a line of code.
There may not appear to be a big story for this change, but coming in without looking at the code, I don't know what cache directory this is referring to, meaning I will have to jump in and read it. Doesn't seem like a big deal, but it might be less obvious 3 years from now.
Knowing which cache directory and where that comes from can be helpful.
Also, as part of this, make sure there's sentence casing, and a Testing Done.
- Description:
-
~ add a cache directory to gitignore
~ Add a cache directory to .gitignore.
+ + When generating test data using
manage.py fill-database, the directoryreviewboard/scmtools/testdata/hg_repo/.hg/wcache/was being consistently generated. It was added to the .gitignore.
- Summary:
-
add a cache directory to gitignoreAdd a cache directory to .gitignore.
- Description:
-
~ Add a cache directory to .gitignore.
~ ~ When generating test data using
manage.py fill-database, the directoryreviewboard/scmtools/testdata/hg_repo/.hg/wcache/was being consistently generated. It was added to the .gitignore.~ When generating test data using
manage.py fill-database,~ the directory reviewboard/scmtools/testdata/hg_repo/.hg/wcache/~ was being consistently generated. It was added to the .gitignore.
