flake8
-
rbintegrations/travisci/tests.py (Diff revision 1) Show all issues
Review Request #10655 — Created Aug. 7, 2019 and submitted
This change adds a missing
HttpResponse
return to the TravisCI
webhook. We didn't notice this before because by the time the error
gets triggered, everything has already been processed and updated, so
it's just something that triggers an error email to the server admins.While I was doing this I found there were a handful of test failures.
Some args-vs-kwargs problems were causing a few tests to error out,
either with a duplicate kwarg error or a type error; these were easily
fixed by specifying kwarg names for allIntegrationForm
instantiations. There were also some warnings coming from kgb about
missingowner=
parameters.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
E501 line too long (82 > 79 characters) |
reviewbot | |
All these plain return statements are problematic too. We have to make sure we're always returning some HttpResponse object. Same … |
chipx86 | |
The error responses should be a HttpResponseBadRequest, so the other end can report that there was a problem instead of … |
chipx86 |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+21 -12) |
rbintegrations/travisci/views.py (Diff revision 2) |
---|
All these plain
return
statements are problematic too. We have to make sure we're always returning someHttpResponse
object.Same in CircleCI.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+29 -20) |
rbintegrations/circleci/views.py (Diff revision 3) |
---|
The error responses should be a
HttpResponseBadRequest
, so the other end can report that there was a problem instead of appearing successful.Honestly, I don't know if Travis CI or CircleCI provide this reporting, but I know plenty of places like GitHub do (and we certainly should start doing that in RB at some point... but I digress).
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+54 -45) |