flake8
failed.
JSHint
passed.
Fix webhook response in TravisCI integration, test failures.
Review Request #10655 — Created Aug. 7, 2019 and submitted
This change adds a missing
HttpResponsereturn to the TravisCI
webhook. We didn't notice this before because by the time the error
gets triggered, everything has already been processed and updated, so
it's just something that triggers an error email to the server admins.While I was doing this I found there were a handful of test failures.
Some args-vs-kwargs problems were causing a few tests to error out,
either with a duplicate kwarg error or a type error; these were easily
fixed by specifying kwarg names for allIntegrationForm
instantiations. There were also some warnings coming from kgb about
missingowner=parameters.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
E501 line too long (82 > 79 characters) |
 reviewbot
|
|
|
All these plain return statements are problematic too. We have to make sure we're always returning some HttpResponse object. Same … |
 chipx86
|
|
|
The error responses should be a HttpResponseBadRequest, so the other end can report that there was a problem instead of … |
chipx86
|
- Commit:
-
e63f42c679fb3c86bd34257aec4e465377af5b3eda06c9977f4b815836eae52582c3c891324d795e
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commit:
-
da06c9977f4b815836eae52582c3c891324d795edcb2d884e27fa8ea13f03bf7478e074c56b8ec59
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
The error responses should be a
HttpResponseBadRequest, so the other end can report that there was a problem instead of appearing successful.Honestly, I don't know if Travis CI or CircleCI provide this reporting, but I know plenty of places like GitHub do (and we certainly should start doing that in RB at some point... but I digress).