Remove potential newline from _find_remote()

Review Request #10653 — Created Aug. 8, 2019 and updated

luisp
RBTools
release-1.0.x
4829
a09e362...
rbtools
We need to strip() the output from "git remote" if get to the case
where we're looking at the output from "git remote" since it may
contain newlines and later break code that includes the return
value of this function as part of another command.

Fixes bug #4829
  • Ran tests
  • Posted this review using the same commandline mentioned in the bug
  • Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch
Description From Last Updated

E501 line too long (103 > 79 characters)

reviewbotreviewbot

F812 list comprehension redefines 'remote' from line 1277

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

luisp
Review request changed

Change Summary:

  • fix flake8 warnings
  • mention additional testing

Testing Done:

   
  • Ran tests
   
  • Posted this review using the same commandline mentioned in the bug
  +
  • Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch

Commit:

-c8cb7fe46133aef6b86af082bb7fa439f9f2e5a7
+a09e362aef018d090f8aa9241566619e2422efa0

Diff:

Revision 2 (+5 -1)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...