Summary

Remove potential newline from _find_remote()

Review Request #10653 — Created Aug. 7, 2019 and updated Aug. 7, 2019, 9:36 p.m.

Information

Owner

luisp

Repository

RBTools

Branch

release-1.0.x

Bugs

4829

Depends On

Commit

a09e362...

Reviewers

Groups

rbtools

People

Description

We need to strip() the output from "git remote" if get to the case
where we're looking at the output from "git remote" since it may
contain newlines and later break code that includes the return
value of this function as part of another command.

Fixes bug #4829

Testing Done


Ran tests
Posted this review using the same commandline mentioned in the bug
Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch

Issues

Description	From	Last Updated
E501 line too long (103 > 79 characters)	reviewbot	Aug. 7, 2019, 9:37 p.m.
F812 list comprehension redefines 'remote' from line 1277	reviewbot	Aug. 7, 2019, 9:37 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (103 > 79 characters)
```
rbtools/clients/git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F812 list comprehension redefines 'remote' from line 1277
```

Change Summary:


fix flake8 warnings
mention additional testing

Testing Done:

		Ran tests
		Posted this review using the same commandline mentioned in the bug
	+	Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch

Commit:

-	c8cb7fe46133aef6b86af082bb7fa439f9f2e5a7
+	a09e362aef018d090f8aa9241566619e2422efa0

Diff:

Revision 2 (+5 -1)

Show changes

rbtools/clients/git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/git.py (Diff revision 1)

rbtools/clients/git.py (Diff revision 1)