Remove potential newline from _find_remote()
Review Request #10653 — Created Aug. 7, 2019 and updated
We need to strip() the output from "git remote" if get to the case where we're looking at the output from "git remote" since it may contain newlines and later break code that includes the return value of this function as part of another command. Fixes bug #4829
- Ran tests
- Posted this review using the same commandline mentioned in the bug
- Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch
- Change Summary:
-
- fix flake8 warnings
- mention additional testing
- Testing Done:
-
- Ran tests
- Posted this review using the same commandline mentioned in the bug
+ - Posted a review for the the original repo/commandline that spawned bug #4829 using this rbtools patch
- Commit:
-
c8cb7fe46133aef6b86af082bb7fa439f9f2e5a7a09e362aef018d090f8aa9241566619e2422efa0
- Diff:
-
Revision 2 (+5 -1)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.