Move the old access policy tests into their modern test suites.

Review Request #10648 — Created July 26, 2019 and submitted

chipx86
Review Board
release-3.0.x
2b76faf...
reviewboard

One of the older sets of unit tests we had was the "policy" tests, which
checked the .accessible() methods on some managers and
.is_accessible_by() methods on some models. These covered Group,
Repository, and ReviewRequest models (and managers), but weren't
part of theor respective test suites.

This gets rid of the old policy test suite, modernizes/cleans up the
tests, and moves them into the proper test suites. This enhances test
coverage and prepares for some upcoming unit tests to refine behavior
and fix bugs.

Unit tests pass.

Description From Last Updated

F401 'django.contrib.auth.models.User' imported but unused

reviewbotreviewbot

F401 'django.contrib.contenttypes.models.ContentType' imported but unused

reviewbotreviewbot

F401 'reviewboard.reviews.models.Group' imported but unused

reviewbotreviewbot

F401 'django.contrib.auth.models.User' imported but unused

reviewbotreviewbot

F841 local variable 'user' is assigned to but never used

reviewbotreviewbot

F401 'django.contrib.auth.models.User' imported but unused

reviewbotreviewbot

F401 'django.contrib.auth.models.User' imported but unused

reviewbotreviewbot

F401 'reviewboard.scmtools.models.Tool' imported but unused

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (1658aa9)
Loading...