Summary

Move the old access policy tests into their modern test suites.

Review Request #10648 — Created July 26, 2019 and submitted July 30, 2019, 4:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

2b76faf...

Reviewers

Groups

reviewboard

People

Description

One of the older sets of unit tests we had was the "policy" tests, which
checked the .accessible() methods on some managers and
.is_accessible_by() methods on some models. These covered Group,
Repository, and ReviewRequest models (and managers), but weren't
part of theor respective test suites.

This gets rid of the old policy test suite, modernizes/cleans up the
tests, and moves them into the proper test suites. This enhances test
coverage and prepares for some upcoming unit tests to refine behavior
and fix bugs.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
F401 'django.contrib.auth.models.User' imported but unused	reviewbot	July 26, 2019, 11:52 p.m.
F401 'django.contrib.contenttypes.models.ContentType' imported but unused	reviewbot	July 26, 2019, 11:52 p.m.
F401 'reviewboard.reviews.models.Group' imported but unused	reviewbot	July 26, 2019, 11:52 p.m.
F401 'django.contrib.auth.models.User' imported but unused	reviewbot	July 26, 2019, 11:52 p.m.
F841 local variable 'user' is assigned to but never used	reviewbot	July 26, 2019, 11:52 p.m.
F401 'django.contrib.auth.models.User' imported but unused	reviewbot	July 26, 2019, 11:53 p.m.
F401 'django.contrib.auth.models.User' imported but unused	reviewbot	July 26, 2019, 11:53 p.m.
F401 'reviewboard.scmtools.models.Tool' imported but unused	reviewbot	July 26, 2019, 11:53 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_review_group.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.models.User' imported but unused
```
reviewboard/reviews/tests/test_review_group.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.contenttypes.models.ContentType' imported but unused
```
reviewboard/reviews/tests/test_review_group.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewboard.reviews.models.Group' imported but unused
```
reviewboard/reviews/tests/test_review_group_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.models.User' imported but unused
```
reviewboard/reviews/tests/test_review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'user' is assigned to but never used
```
reviewboard/scmtools/tests/test_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.models.User' imported but unused
```
reviewboard/scmtools/tests/test_repository_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.models.User' imported but unused
```
reviewboard/scmtools/tests/test_repository_manager.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewboard.scmtools.models.Tool' imported but unused
```

Change Summary:

Removed unused imports and variables.

Commit:

8c5432fc663d60adff0c6a2cd1c32bff939c486e

2b76faf73b7aa16b54479d17124ce39a1a72b3ee

Diff:

Revision 2 (+754 -265)

Show changes

	reviewboard/reviews/tests/test_policy.py
	reviewboard/reviews/tests/test_review_group.py
	reviewboard/reviews/tests/test_review_group_manager.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/scmtools/tests/test_repository.py
	reviewboard/scmtools/tests/test_repository_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (1658aa9)