Summary

Update to the latest CodeMirror release.

Review Request #10647 — Created July 26, 2019 and submitted July 31, 2019, 12:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

CodeMirror has had a bunch of releases since we last updated. Most of
these deal with individual modes, but there have been some good bugfixes
that we want to pick up. This change updates us to the latest released
version, 5.48.2. As part of this I've updated the instructions for
building the file to cope with changes in their tree (the removal of the
compress script) and switched us to bundling an un-minified file,
which makes things easier for debugging.

Testing Done

Smoke tested various text editors and different features of the editor.

Commits

Summary	ID
Update to the latest CodeMirror release. CodeMirror has had a bunch of releases since we last updated. Most of these deal with individual modes, but there have been some good bugfixes that we want to pick up. This change updates us to the latest released version, 5.48.2. As part of this I've updated the instructions for building the file to cope with changes in their tree (the removal of the `compress` script) and switched us to bundling an un-minified file, which makes things easier for debugging. Testing Done: Smoke tested various text editors and different features of the editor.	459bc8feecaae672068350a7d5b29c6be27f0c62

Summary

Update to the latest CodeMirror release.

CodeMirror has had a bunch of releases since we last updated. Most of these deal with individual modes, but there have been some good bugfixes that we want to pick up. This change updates us to the latest released version, 5.48.2. As part of this I've updated the instructions for building the file to cope with changes in their tree (the removal of the `compress` script) and switched us to bundling an un-minified file, which makes things easier for debugging. Testing Done: Smoke tested various text editors and different features of the editor.

459bc8feecaae672068350a7d5b29c6be27f0c62

Issues

Description	From	Last Updated
Col: 33 Expected an assignment or function call and instead saw an expression.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 69 Expected '===' and instead saw '=='.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 81 Missing semicolon.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 49 Missing semicolon.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	July 26, 2019, 1:49 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 24 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 38 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 28 Expected '===' and instead saw '=='.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 19 Expected '===' and instead saw '=='.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 41 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 38 Expected a conditional expression and instead saw an assignment.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 39 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 25 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 13 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 49 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 50 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 18 Missing semicolon.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 74 A leading decimal point can be confused with a dot: '.85'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 22 A leading decimal point can be confused with a dot: '.005'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 38 A leading decimal point can be confused with a dot: '.005'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 38 A leading decimal point can be confused with a dot: '.53'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 46 A leading decimal point can be confused with a dot: '.7'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 85 A leading decimal point can be confused with a dot: '.5'.	reviewbot	July 26, 2019, 1:50 p.m.
Col: 46 A leading decimal point can be confused with a dot: '.5'.	reviewbot	July 26, 2019, 1:50 p.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 33
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 69
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 81
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 49
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 24
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 28
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 19
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 41
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 Expected a conditional expression and instead saw an assignment.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 39
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 25
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 49
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 50
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 18
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 74
 A leading decimal point can be confused with a dot: '.85'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 22
 A leading decimal point can be confused with a dot: '.005'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 A leading decimal point can be confused with a dot: '.005'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 38
 A leading decimal point can be confused with a dot: '.53'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 46
 A leading decimal point can be confused with a dot: '.7'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 85
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/codemirror-5.48.2.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 46
 A leading decimal point can be confused with a dot: '.5'.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (38c89cc)