Summary

Rename Settings to ExtensionSettings and improve documentation.

Review Request #10641 — Created July 23, 2019 and submitted July 26, 2019, 10:44 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Commit

4dac336...

Reviewers

Groups

djblets

People

Description

The object that managed an extension's settings was called Settings,
which was a bit too generic and capable of conflicts. It also didn't
match the naming scheme of most other core Extension classes.

This change renames it to ExtensionSettings and improves its
documentation. It keeps an older Settings alias around for any legacy
purposes, which we'll remove in Djblets 3.0.

Testing Done

Unit tests pass.

flake8 passed.

JSHint passed.

Change Summary:

Added missing files to the change.

Commit:

-	47baa2833b39de9fc9a588ca10eb6c9f651bb6d6
+	4dac336dee47e53cd748bdd6d30519529a87aff2

Diff:

Revision 2 (+89 -30)

Show changes

	djblets/extensions/base.py
	djblets/extensions/extension.py
	djblets/extensions/settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (04f3626)