Fix regressions in the repository form ES6 transition.

Review Request #10626 — Created July 15, 2019 and submitted

chipx86
Review Board
release-4.0.x
2c3cf0e...
reviewboard

When the repository form's code was moved to ES6, there were a couple of
regressions that broke the form's functionality.

First, the page was crashing when trying to set the help text. It was
attempting to use a variable that was no longer defined. We now just
pass the value originally set for that variable into the function that
needed it.

Second, a typo in a selector resulted in SCMTool-specific rows not being
hidden properly, causing some confusion when trying to configure a
hosting service.

This brings the repository form back to working order.

Created some repositories and switched between hosting services and
repository types. Everything appeared to behave as expected.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (703cffb)
Loading...