Fix a regression from the feature checker tests.

Review Request #10620 — Created July 8, 2019 and submitted

chipx86
Review Board
release-3.0.x
c74a8a0...
reviewboard

The recent change to feature checkers introduced a change that regressed
some tests. There was a fix for the tests that weren't staged along with
the rest of the change, meaning that once the change went in, our tests
failed.

Since they got left out, I took the opportunity to redo the approach,
which previously was to pass a local_site= argument to the feature
checker's is_feature_enabled(). However, this change instead adds a
new flag, force_check_user_local_sites, that disables the new
test-only logic that excludes Local Site memberships from the feature
calculation. This is now passed in the necessary tests.

Unit tests pass.

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (7adeb88)
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (7adeb88)
Loading...