Summary

Fix RelatedUserWidget regressions from recent avatar changes.

Review Request #10608 — Created June 22, 2019 and submitted July 2, 2019, 1:59 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The RelatedUserWidget HTML includes information on user avatars for
rendering purposes. Recently, Djblets avatar rendering was updated to
provide HTML instead of just URLs for this widget, in order to support
the fallback avatar service. This regressed some tests we had only on
Review Board 4.0.

This change updates the HTML comparison in a test for the new rendering.

Testing Done

Unit tests pass against Django 1.6 and 1.11.

Commits

Summary	ID
Fix RelatedUserWidget regressions from recent avatar changes. The `RelatedUserWidget` HTML includes information on user avatars for rendering purposes. Recently, Djblets avatar rendering was updated to provide HTML instead of just URLs for this widget, in order to support the fallback avatar service. This regressed some tests we had only on Review Board 4.0. This change updates the HTML comparison in a test for the new rendering.	73fcccb811fd6a8e152e2f0d7298eaf16ab416ce

Summary

Fix RelatedUserWidget regressions from recent avatar changes.

The `RelatedUserWidget` HTML includes information on user avatars for rendering purposes. Recently, Djblets avatar rendering was updated to provide HTML instead of just URLs for this widget, in order to support the fallback avatar service. This regressed some tests we had only on Review Board 4.0. This change updates the HTML comparison in a test for the new rendering.

73fcccb811fd6a8e152e2f0d7298eaf16ab416ce

Issues

Description	From	Last Updated
E501 line too long (117 > 79 characters)	reviewbot	June 22, 2019, 10:35 p.m.
E501 line too long (107 > 79 characters)	reviewbot	June 22, 2019, 10:35 p.m.
E501 line too long (109 > 79 characters)	reviewbot	June 22, 2019, 10:35 p.m.
E501 line too long (117 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.
E501 line too long (107 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.
E501 line too long (109 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.
E501 line too long (117 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.
E501 line too long (107 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.
E501 line too long (109 > 79 characters)	reviewbot	June 22, 2019, 10:36 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (117 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (109 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (117 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (109 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (117 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/admin/tests/test_related_user_widget.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (109 > 79 characters)
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (e533e0a)