chipx86 got a fish trophy!

Summary

Fix a regression with creating pending references to models on Django 1.6.

Review Request #10601 — Created June 18, 2019 and submitted June 19, 2019, 3:59 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

A recent change to split sql_create_models() passed the wrong model to
a call to sql_for_pending_references(), which resulted in some bad SQL
that would break on MySQL. We were executing SQL for creating pending
references on the model being created when we meant to do that for
models being referenced by the model (via a ForeignKey or similar
fields). This change fixes that variable, fixing all tests.

Testing Done

All unit tests pass for all databases.

Commits

Summary	ID
Fix a regression with creating pending references to models on Django 1.6. A recent change to split `sql_create_models()` passed the wrong model to a call to `sql_for_pending_references()`, which resulted in some bad SQL that would break on MySQL. We were executing SQL for creating pending references on the model being created when we meant to do that for models being referenced by the model (via a `ForeignKey` or similar fields). This change fixes that variable, fixing all tests.	b8012d0bcd1956f44f7f91f7a381965781c1f881

Summary

Fix a regression with creating pending references to models on Django 1.6.

A recent change to split `sql_create_models()` passed the wrong model to a call to `sql_for_pending_references()`, which resulted in some bad SQL that would break on MySQL. We were executing SQL for creating pending references on the model being created when we meant to do that for models being referenced by the model (via a `ForeignKey` or similar fields). This change fixes that variable, fixing all tests.

b8012d0bcd1956f44f7f91f7a381965781c1f881

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (b1c31f9)