Fish Trophy

chipx86 got a fish trophy!

Fish Trophy

Fix a regression with creating pending references to models on Django 1.6.

Review Request #10601 — Created June 18, 2019 and submitted

Information

Django Evolution
master

Reviewers

A recent change to split sql_create_models() passed the wrong model to
a call to sql_for_pending_references(), which resulted in some bad SQL
that would break on MySQL. We were executing SQL for creating pending
references on the model being created when we meant to do that for
models being referenced by the model (via a ForeignKey or similar
fields). This change fixes that variable, fixing all tests.

All unit tests pass for all databases.

Summary ID
Fix a regression with creating pending references to models on Django 1.6.
A recent change to split `sql_create_models()` passed the wrong model to a call to `sql_for_pending_references()`, which resulted in some bad SQL that would break on MySQL. We were executing SQL for creating pending references on the model being created when we meant to do that for models being referenced by the model (via a `ForeignKey` or similar fields). This change fixes that variable, fixing all tests.
b8012d0bcd1956f44f7f91f7a381965781c1f881
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (b1c31f9)