Further bullet-proof Bitbucket webhook payload parsing.

Review Request #10595 — Created June 17, 2019 and submitted

Information

Review Board
release-3.0.x

Reviewers

A recent change attempted to deal with Bitbucket payload changes that
resulted in fields sometimes not being present in the payload, depending
on the event that fired. We've since found that sometimes the keys are
present, but are null, breaking some of our parsing. This change further
improves it, handling both missing keys and null values for those keys,
and falling back to defaults in both cases.

Unit tests pass.

Summary ID
Further bullet-proof Bitbucket webhook payload parsing.
A recent change attempted to deal with Bitbucket payload changes that resulted in fields sometimes not being present in the payload, depending on the event that fired. We've since found that sometimes the keys are present, but are null, breaking some of our parsing. This change further improves it, handling both missing keys and null values for those keys, and falling back to defaults in both cases.
3540e45921d11c8446c57ea573071c149b1f0126
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7f04e3f)
Loading...