Don't include ) or ] in bug link
Review Request #10594 — Created June 15, 2019 and submitted
Makes references like "(see issue #abc)" work as expected. Also modify existing linkifyText test lines to be <= 79 chars.
Unit test.
Summary | ID |
---|---|
444b21c8da6d2c23205da3fbc4c7c6694c026d11 |
Description | From | Last Updated |
---|---|---|
Can you make sure this fits in <= 79 chars? I know some of the others have this issue as … |
|
|
Since this is an ES6 file we should use const instead of var. Let's also add a blank line between … |
|
|
Col: 53 Script URL. |
![]() |
|
Col: 55 Script URL. |
![]() |
|
Can you add a blank line after this? |
|
|
const, blank line. |
|
|
Col: 53 Script URL. |
![]() |
|
Col: 55 Script URL. |
![]() |
-
Thanks for the ping on this. We've been pretty busy with a major update of everything for Django 1.11 and eventually Python 3 (btw, only planned to be officially supported under RB5, RB4 with a custom contract). So we haven't been looking much at contributions. I'll get this in for 3.0, though, after the below fix.
-
reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.es6.js (Diff revision 1) Can you make sure this fits in <= 79 chars? I know some of the others have this issue as well, but you could update this one to save the linkified text in a variable and then just compare the variable.
Change Summary:
Make all linkifyText test lines be <= 79 chars.
Description: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||
Diff: |
Revision 2 (+86 -60) |
Checks run (1 failed, 1 succeeded)
JSHint
-
-
reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.es6.js (Diff revision 2) Since this is an ES6 file we should use
const
instead ofvar
. Let's also add a blank line between this line and the next for readability. -
reviewboard/static/rb/js/utils/tests/linkifyUtilsTests.es6.js (Diff revision 2) Can you add a blank line after this?
-
Change Summary:
var -> const and new lines
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+92 -60) |