Fix an iteration ordering issue with RB.ReviewRequestActionHook.

Review Request #10588 — Created June 11, 2019 and submitted — Latest diff uploaded

Information

Review Board
release-3.0.x

Reviewers

The JavaScript RB.ReviewRequestActionHook had an issue with the order
of data when iterating through the list of registered hooks. What we
documented in the manual was correct, but the code implementation
wasn't. This meant that anyone following the docs would find that their
hooks weren't doing anything but crashing.

This is a simple fix that switches the ordering to be correct.

Unit tests pass.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.
81af6ecf1051f96d7453491ce47d554da9849521 Christian Hammond
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
Loading...