Fix an iteration ordering issue with RB.ReviewRequestActionHook.

Review Request #10588 — Created June 11, 2019 and submitted

chipx86
Review Board
release-3.0.x
reviewboard

The JavaScript RB.ReviewRequestActionHook had an issue with the order
of data when iterating through the list of registered hooks. What we
documented in the manual was correct, but the code implementation
wasn't. This meant that anyone following the docs would find that their
hooks weren't doing anything but crashing.

This is a simple fix that switches the ordering to be correct.

Unit tests pass.

Summary
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
Description From Last Updated

Col: 21 Do not use 'new' for side effects.

reviewbotreviewbot

Col: 21 Do not use 'new' for side effects.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
Review request changed

Change Summary:

Removed an extra console.log.

Commits:

Summary
-
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
+
Fix an iteration ordering issue with RB.ReviewRequestActionHook.

Diff:

Revision 2 (+80 -10)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e85d7ce)
Loading...