Summary

Fix an iteration ordering issue with RB.ReviewRequestActionHook.

Review Request #10588 — Created June 11, 2019 and submitted June 11, 2019, 10:02 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The JavaScript RB.ReviewRequestActionHook had an issue with the order
of data when iterating through the list of registered hooks. What we
documented in the manual was correct, but the code implementation
wasn't. This meant that anyone following the docs would find that their
hooks weren't doing anything but crashing.

This is a simple fix that switches the ordering to be correct.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix an iteration ordering issue with RB.ReviewRequestActionHook. The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.	81af6ecf1051f96d7453491ce47d554da9849521

Summary

Fix an iteration ordering issue with RB.ReviewRequestActionHook.

The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.

81af6ecf1051f96d7453491ce47d554da9849521

Issues

Description	From	Last Updated
Col: 21 Do not use 'new' for side effects.	reviewbot	June 11, 2019, 9:45 p.m.
Col: 21 Do not use 'new' for side effects.	reviewbot	June 11, 2019, 9:52 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 Do not use 'new' for side effects.
```

Change Summary:

Removed an extra console.log.

Commits:

	Summary	ID
	Fix an iteration ordering issue with RB.ReviewRequestActionHook. The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.	4096aa3641e5b4e8fa6df8aafbfa90878cc92224
	Fix an iteration ordering issue with RB.ReviewRequestActionHook. The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.	81af6ecf1051f96d7453491ce47d554da9849521

Diff:

Revision 2 (+80 -10)

Show changes

	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 21
 Do not use 'new' for side effects.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (e85d7ce)