Fix an iteration ordering issue with RB.ReviewRequestActionHook.

Review Request #10588 — Created June 11, 2019 and submitted

Information

Review Board
release-3.0.x

Reviewers

The JavaScript RB.ReviewRequestActionHook had an issue with the order
of data when iterating through the list of registered hooks. What we
documented in the manual was correct, but the code implementation
wasn't. This meant that anyone following the docs would find that their
hooks weren't doing anything but crashing.

This is a simple fix that switches the ordering to be correct.

Unit tests pass.

Summary ID
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.
81af6ecf1051f96d7453491ce47d554da9849521
Description From Last Updated

Col: 21 Do not use 'new' for side effects.

reviewbotreviewbot

Col: 21 Do not use 'new' for side effects.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
Review request changed
Change Summary:

Removed an extra console.log.

Commits:
Summary ID
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.
4096aa3641e5b4e8fa6df8aafbfa90878cc92224
Fix an iteration ordering issue with RB.ReviewRequestActionHook.
The JavaScript `RB.ReviewRequestActionHook` had an issue with the order of data when iterating through the list of registered hooks. What we documented in the manual was correct, but the code implementation wasn't. This meant that anyone following the docs would find that their hooks weren't doing anything but crashing. This is a simple fix that switches the ordering to be correct.
81af6ecf1051f96d7453491ce47d554da9849521

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (e85d7ce)