Summary

Set the app label on all test models.

Review Request #10571 — Created May 30, 2019 and submitted June 17, 2019, 2:48 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

This introduces a new BaseTestModel that sets the app label,
preventing those models from being registered under the
django_evolution app. While we try to do this during the test app
setup phase, it doesn't catch the models that are simply defined within
tests, requiring that we set these correctly.

Testing Done

Unit tests pass on all supported versions.

Commits

Summary	ID
Set the app label on all test models. This introduces a new `BaseTestModel` that sets the app label, preventing those models from being registered under the `django_evolution` app. While we try to do this during the test app setup phase, it doesn't catch the models that are simply defined within tests, requiring that we set these correctly.	f73ce739fba392307122813c62f33101f4c9a4c5

flake8 passed.

JSHint passed.

Change Summary:

Added a missing docstring.

Commits:

	Summary	ID
	Set the app label on all test models. This introduces a new `BaseTestModel` that sets the app label, preventing those models from being registered under the `django_evolution` app. While we try to do this during the test app setup phase, it doesn't catch the models that are simply defined within tests, requiring that we set these correctly.	ac72c3e147c8af4e67ac1e4c749ce631c63700e9
	Set the app label on all test models. This introduces a new `BaseTestModel` that sets the app label, preventing those models from being registered under the `django_evolution` app. While we try to do this during the test app setup phase, it doesn't catch the models that are simply defined within tests, requiring that we set these correctly.	f73ce739fba392307122813c62f33101f4c9a4c5

Diff:

Revision 2 (+520 -446)

Show changes

	django_evolution/tests/models.py
	django_evolution/tests/test_add_field.py
	django_evolution/tests/test_change_field.py
	django_evolution/tests/test_change_meta.py
	django_evolution/tests/test_delete_app.py
	django_evolution/tests/test_delete_field.py
	django_evolution/tests/test_delete_model.py
	django_evolution/tests/test_diff.py
	10 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (05936ea)