Use native string type for envvars passed to Popen.

 






 

 


  Review Request #10548
  —
  Created May 8, 2019 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-1.0.x
 









 
 

  4818
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
On Linux and Mac, Python is pretty flexible about whether the

environment dictionary contains bytestrings or unicode, but Windows is

stricter. We were initially forcing everything to be bytes, but Python

3 on Windows wants str, so this change switches to that instead.

 








  


 
 

  
Ran unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Use native string type for envvars passed to Popen.
      
On Linux and Mac, Python is pretty flexible about whether the
environment dictionary contains bytestrings or unicode, but Windows is
stricter. We were initially forcing everything to be `bytes`, but Python
3 on Windows wants `str`, so this change switches to that instead.

Testing Done:
Ran unit tests.

Fixes bug 4818.

     


    		
    da5cd328de3bab3059a45e06a213f9f2be1741ae

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-1.0.x (a32dadb)





 


 










  

 









     

    

   

  

  

   
   Loading...