Summary

Use native string type for envvars passed to Popen.

Review Request #10548 — Created May 8, 2019 and submitted May 13, 2019, 11:49 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-1.0.x

Bugs

4818

Depends On

Reviewers

Groups

rbtools

People

Description

On Linux and Mac, Python is pretty flexible about whether the
environment dictionary contains bytestrings or unicode, but Windows is
stricter. We were initially forcing everything to be bytes, but Python
3 on Windows wants str, so this change switches to that instead.

Testing Done

Ran unit tests.

Commits

Summary	ID
Use native string type for envvars passed to Popen. On Linux and Mac, Python is pretty flexible about whether the environment dictionary contains bytestrings or unicode, but Windows is stricter. We were initially forcing everything to be `bytes`, but Python 3 on Windows wants `str`, so this change switches to that instead. Testing Done: Ran unit tests. Fixes bug 4818.	da5cd328de3bab3059a45e06a213f9f2be1741ae

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (a32dadb)