Summary

Update the dependencies and package install for Python 3.x.

Review Request #10530 — Created April 13, 2019 and submitted May 17, 2019, 2:17 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We're now supporting Python 3.6 as a minimum for the 3.x range. This is
enforced in setup.py and manage.py, with the minimum versions now
defined in dependencies.py.

setup.py now permits packaging if setting the environment variable
RB_PY3_HAS_NO_OFFICIAL_SUPPORT=agreed. This helps with the
development and testing of the packaging while at the same time making
it clear to anyone doing so that we are not supporting this version yet.

It also bumps the minimum Django 1.11 release to the latest 1.11.20.

Testing Done

Tested running develop and bdist_wheel on Python 2.7, 3.6, and 3.7.

Tested that older Python versions triggered appropriate failures to run
setup.py and manage.py.

Commits

Summary	ID
Update the dependencies and package install for Python 3.x. We're now supporting Python 3.6 as a minimum for the 3.x range. This is enforced in `setup.py` and `manage.py`, with the minimum versions now defined in `dependencies.py`. `setup.py` now permits packaging if setting the environment variable `RB_PY3_HAS_NO_OFFICIAL_SUPPORT=agreed`. This helps with the development and testing of the packaging while at the same time making it clear to anyone doing so that we are not supporting this version yet.	ce3676cca637d0b26371664a5a66ef4e48f7dc22

Summary

Update the dependencies and package install for Python 3.x.

We're now supporting Python 3.6 as a minimum for the 3.x range. This is enforced in `setup.py` and `manage.py`, with the minimum versions now defined in `dependencies.py`. `setup.py` now permits packaging if setting the environment variable `RB_PY3_HAS_NO_OFFICIAL_SUPPORT=agreed`. This helps with the development and testing of the packaging while at the same time making it clear to anyone doing so that we are not supporting this version yet.

ce3676cca637d0b26371664a5a66ef4e48f7dc22

Issues

Description	From	Last Updated
F401 'django' imported but unused	reviewbot	April 13, 2019, 1:38 a.m.
F821 undefined name 'PYTHON_2_MIN_VERSION'	reviewbot	April 13, 2019, 1:39 a.m.
F821 undefined name 'PYTHON_3_MIN_VERSION'	reviewbot	April 13, 2019, 1:39 a.m.
F821 undefined name 'PYTHON_2_MIN_VERSION'	reviewbot	April 13, 2019, 1:40 a.m.
F821 undefined name 'PYTHON_3_MIN_VERSION'	reviewbot	April 13, 2019, 1:40 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django' imported but unused
```
reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'PYTHON_2_MIN_VERSION'
```
reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'PYTHON_3_MIN_VERSION'
```
reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'PYTHON_2_MIN_VERSION'
```
reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'PYTHON_3_MIN_VERSION'
```

Change Summary:


Fixed some imports.
Fixed an error message.

Commits:

	Summary	ID
	Update the dependencies and package install for Python 3.x. We're now supporting Python 3.6 as a minimum for the 3.x range. This is enforced in `setup.py` and `manage.py`, with the minimum versions now defined in `dependencies.py`. `setup.py` now permits packaging if setting the environment variable `RB_PY3_HAS_NO_OFFICIAL_SUPPORT=agreed`. This helps with the development and testing of the packaging while at the same time making it clear to anyone doing so that we are not supporting this version yet.	3bdb698c7ab77e6db99e537f43ec6d82c9b42e8d
	Update the dependencies and package install for Python 3.x. We're now supporting Python 3.6 as a minimum for the 3.x range. This is enforced in `setup.py` and `manage.py`, with the minimum versions now defined in `dependencies.py`. `setup.py` now permits packaging if setting the environment variable `RB_PY3_HAS_NO_OFFICIAL_SUPPORT=agreed`. This helps with the development and testing of the packaging while at the same time making it clear to anyone doing so that we are not supporting this version yet.	ce3676cca637d0b26371664a5a66ef4e48f7dc22

Diff:

Revision 2 (+92 -28)

Show changes

	setup.py
	reviewboard/dependencies.py
	reviewboard/manage.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (05f8762)

reviewboard/manage.py (Diff revision 1)

reviewboard/manage.py (Diff revision 1)

reviewboard/manage.py (Diff revision 1)

reviewboard/manage.py (Diff revision 1)