Improve CommitListField HTML rendered in changedescs
Review Request #10522 — Created April 9, 2019 and updated — Latest diff uploaded
The CommitListField now renders change description entries for the field
more similarily to its regular field view. Previously, it would just
show all old commits as removed and all new commits as added, but now it
performs a history diff between the old and new commits and renders that
instead.The new template supports rendering commit modifications, however
commit_utils.diff_histories
presently cannot generate history diffs
that contain modifications (only additions, deletions, and unmodified
entries).
Ran unit tests.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
orig
1
2
3
4
5
Commits
reviewboard/reviews/builtin_fields.py |
---|
reviewboard/reviews/tests/test_builtin_fields.py |
---|
reviewboard/static/rb/css/pages/reviews.less |
---|
reviewboard/templates/reviews/changedesc_commit_list.html |
---|