flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/builtin_fields.py (Diff revision 1) Show all issues
Improve CommitListField HTML rendered in changedescs
Review Request #10522 — Created April 9, 2019 and updated
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-4.0.x | |
| Reviewers | |
| reviewboard | |
The CommitListField now renders change description entries for the field
more similarily to its regular field view. Previously, it would just
show all old commits as removed and all new commits as added, but now it
performs a history diff between the old and new commits and renders that
instead.The new template supports rendering commit modifications, however
commit_utils.diff_historiespresently cannot generate history diffs
that contain modifications (only additions, deletions, and unmodified
entries).
Ran unit tests.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Can you add screenshots? |
 chipx86
|
|
|
F841 local variable 'to_expand' is assigned to but never used |
 reviewbot
|
|
|
F841 local variable 'to_expand' is assigned to but never used |
reviewbot
|
|
|
Instead of defining yet another color constant for me to replace, how about just defining the background color for .changed … |
 david
|
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+462 -102) |
|||||||||
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/builtin_fields.py (Diff revision 2) F841 local variable 'to_expand' is assigned to but never used
Testing Done: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||
Diff: |
Revision 3 (+458 -102) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
attach unit tests
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+456 -102) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Added screenshots.
NOTE:
In the "Modifying a single commit (after)" screenshot,
diff_historiescannot detect commit modifications, so this is a screenshot of what it would look like if it could.
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Added Files: |
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+472 -104) |
|||||||||
Removed Files: |
||||||||||
Added Files: |
||||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/css/defs.less (Diff revision 5) Instead of defining yet another color constant for me to replace, how about just defining the background color for
.changed tdas a variable and then usingdarken(..., ...)?