Improve CommitListField HTML rendered in changedescs

Review Request #10522 — Created April 9, 2019 and updated

Information

Review Board
release-4.0.x

Reviewers

The CommitListField now renders change description entries for the field
more similarily to its regular field view. Previously, it would just
show all old commits as removed and all new commits as added, but now it
performs a history diff between the old and new commits and renders that
instead.

The new template supports rendering commit modifications, however
commit_utils.diff_histories presently cannot generate history diffs
that contain modifications (only additions, deletions, and unmodified
entries).

Ran unit tests.

Summary ID
Improve CommitListField HTML rendered in changedescs
The CommitListField now renders change description entries for the field more similarily to its regular field view. Previously, it would just show all old commits as removed and all new commits as added, but now it performs a history diff between the old and new commits and renders that instead. The new template supports rendering commit modifications, however `commit_utils.diff_histories` presently cannot generate history diffs that contain modifications (only additions, deletions, and unmodified entries). Testing done: Ran unit tests.
1d5306bd97fe94ee92cb442c2d35d09ad8928f67

Description From Last Updated

Can you add screenshots?

chipx86chipx86

F841 local variable 'to_expand' is assigned to but never used

reviewbotreviewbot

F841 local variable 'to_expand' is assigned to but never used

reviewbotreviewbot

Instead of defining yet another color constant for me to replace, how about just defining the background color for .changed …

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
Review request changed
Commits:
Summary ID
Improve CommitListField HTML rendered in changedescs
The CommitListField now renders change description entries for the field more similarily to its regular field view. Previously, it would just show all old commits as removed and all new commits as added, but now it performs a history diff between the old and new commits and renders that instead. Testing done: - Ran unit tests.
cc056f539b473aa24400a99e6f5b13a0b58be6bf
Improve CommitListField HTML rendered in changedescs
The CommitListField now renders change description entries for the field more similarily to its regular field view. Previously, it would just show all old commits as removed and all new commits as added, but now it performs a history diff between the old and new commits and renders that instead. Testing done: Ran unit tests.
05b9937d190618fd8d37f896bfe02a2f15bfd95c

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
brennie
chipx86
  1. 
      
  2. Show all issues

    Can you add screenshots?

  3. 
      
brennie
brennie
Review request changed
Commits:
Summary ID
Improve CommitListField HTML rendered in changedescs
The CommitListField now renders change description entries for the field more similarily to its regular field view. Previously, it would just show all old commits as removed and all new commits as added, but now it performs a history diff between the old and new commits and renders that instead. Testing done: Ran unit tests.
6b417754f3bbcb0af7a19619e0060cae5d8a19b6
Improve CommitListField HTML rendered in changedescs
The CommitListField now renders change description entries for the field more similarily to its regular field view. Previously, it would just show all old commits as removed and all new commits as added, but now it performs a history diff between the old and new commits and renders that instead. The new template supports rendering commit modifications, however `commit_utils.diff_histories` presently cannot generate history diffs that contain modifications (only additions, deletions, and unmodified entries). Testing done: Ran unit tests.
1d5306bd97fe94ee92cb442c2d35d09ad8928f67
Removed Files:
Added Files:

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. 
      
  2. reviewboard/static/rb/css/defs.less (Diff revision 5)
     
     
    Show all issues

    Instead of defining yet another color constant for me to replace, how about just defining the background color for .changed td as a variable and then using darken(..., ...)?

  3.