Improve CommitListField HTML rendered in changedescs

Review Request #10522 — Created April 9, 2019 and updated

brennie
Review Board
release-4.0.x
reviewboard

The CommitListField now renders change description entries for the field
more similarily to its regular field view. Previously, it would just
show all old commits as removed and all new commits as added, but now it
performs a history diff between the old and new commits and renders that
instead.

The new template supports rendering commit modifications, however
commit_utils.diff_histories presently cannot generate history diffs
that contain modifications (only additions, deletions, and unmodified
entries).

Ran unit tests.

Summary
Improve CommitListField HTML rendered in changedescs
Loading file attachments...

Description From Last Updated

Can you add screenshots?

chipx86chipx86

F841 local variable 'to_expand' is assigned to but never used

reviewbotreviewbot

F841 local variable 'to_expand' is assigned to but never used

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
Review request changed

Commits:

Summary
-
Improve CommitListField HTML rendered in changedescs
+
Improve CommitListField HTML rendered in changedescs

Diff:

Revision 2 (+462 -102)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
brennie
chipx86
  1. 
      
  2. Can you add screenshots?

  3. 
      
brennie
brennie
Review request changed

Commits:

Summary
-
Improve CommitListField HTML rendered in changedescs
+
Improve CommitListField HTML rendered in changedescs

Diff:

Revision 5 (+472 -104)

Show changes

Removed Files:

Added Files:

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...